Repository navigation
Do not use the "function" keyword - #255
CyrilRoelandteNovance wants to merge 1 commit into
Conversation
elfiesmelfie
left a comment
There was a problem hiding this comment.
Looks okay to me, but please solicit feedback from horizon and tempest contributers.
| } | ||
|
|
||
|
|
||
| # This function ensures all arguments are handled properly: |
There was a problem hiding this comment.
Your regular expression needs tuning :)
Please restore this line for future grok-ability
There was a problem hiding this comment.
Yes, there were two lines like these :) My sed skills escaped me for a second. Nice catch!
The "function" keyword is non standard. In most shell scripts in this repository, it is not used. Let us be consistent and never use it.
138e7cf to
ba4e6ed
Compare
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Build failed (check pipeline). Post ❌ horizon-s2i-test POST_FAILURE in 15m 19s |
|
recheck |
|
Build succeeded (check pipeline). ✔️ horizon-s2i-test SUCCESS in 1h 42m 42s |
The "function" keyword is non standard. In most shell scripts in this
repository, it is not used. Let us be consistent and never use it.