Conversation
agentzh
requested changes
Jan 9, 2018
| + --openssldir="%cd%/openssl/ssl" \ | ||
| + $(OPENSSL_OPT) | ||
| + | ||
| + if exist ms\do_win64a.bat ( \ |
Member
There was a problem hiding this comment.
The trailing \ is not aligned up vertically.
|
|
||
| $OPENSSL/openssl/include/openssl/ssl.h: $NGX_MAKEFILE | ||
| - \$(MAKE) -f auto/lib/openssl/makefile.msvc \ | ||
| + \$(MAKE) -f auto/lib/openssl/makefile-$NGX_MSVC_TYPE.msvc \ |
Member
There was a problem hiding this comment.
The trailing \ is not aligned up vertically.
Author
There was a problem hiding this comment.
You forgot to mention there are also tabs instead of spaces :)
Actually those \ symbols are not aligned in the original file "makefile.msvc" used as a base.
I've aligned them.
| + --openssldir="%cd%/openssl/ssl" \ | ||
| + $(OPENSSL_OPT) | ||
| + | ||
| + if exist ms\do_nasm.bat ( \ |
Member
|
@geniuss99 BTW, will you rename your patch to 1.13.6? We have no patches for 1.13.7 and also no plan to use that nginx core (we may directly jump to nginx 1.13.8 or even beyond in the future). |
Author
|
Done. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I hereby granted the copyright of the changes in this pull request to the authors of this openresty project.
This pull request is related to
lua-nginx-modulefeature:openresty/lua-nginx-module#1222