Sitelet https://github.com/openmcdf/openmcdf/pull/74
Skip to content

Fix padding reading in TypedPropertyValue - #74

Merged
ironfede merged 1 commit into
openmcdf:masterfrom
hughbe:patch-1
Apr 23, 2023
Merged

ironfede merged 1 commit into
openmcdf:masterfrom
hughbe:patch-1

Conversation

@hughbe

@hughbe hughbe commented Nov 5, 2020

Copy link
Copy Markdown
Contributor
  • E.g. If the start position is 0 and the end position is 13, then size = 13-0=13, m = (int)size % 4=1, so we don't need m bytes of padding, but actually 4

@ironfede

Copy link
Copy Markdown
Collaborator

Thank you @hughbe and sorry for delayed response.
I will include it in next release of Extensions package. Btw I've noticed that your comment should be "...actually 4 -m " since this is the change you've correctly implemented in PR.
Many thanks,
Federico

@ironfede
ironfede merged commit cee9924 into openmcdf:master Apr 23, 2023
@hughbe
hughbe deleted the patch-1 branch April 24, 2023 06:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants