Sitelet https://github.com/open-telemetry/opentelemetry-dotnet-contrib/pull/5381
Skip to content

[Infra] xunit v3 preparation - #5381

Merged
martincostello merged 1 commit into
open-telemetry:mainfrom
martincostello:xunit-v3-prep
Sep 23, 2026
Merged

martincostello merged 1 commit into
open-telemetry:mainfrom
martincostello:xunit-v3-prep

Conversation

@martincostello

@martincostello martincostello commented Sep 23, 2026 •

Copy link
Copy Markdown
Member

Relates to open-telemetry/opentelemetry-dotnet#7740.

(Sorry for the size of the PR)

Changes

  • Fix test flakiness identified under xunit v3's changed execution model for async.
  • Add new dedicated MSBuild property for test TFM for .NET Framework.
  • Avoid 4.6.2-specific conditions and instead make them ".NET Framework".
  • Add shim to allow using xunit.v3's TestContext class to pass CancellationTokens to methods under test now.
  • Cherry-pick some code analyser fixes from [Infra] Support .NET 11 #3867.
  • Remove redundant comments.

Merge requirement checklist

  • CONTRIBUTING guidelines followed (license requirements, nullable enabled, static analysis, etc.)
  • Unit tests added/updated
  • Appropriate CHANGELOG.md files updated for non-trivial changes
  • Changes in public API reviewed (if applicable)

- Fix test flakiness identified under xunit v3's changed execution model for async.
- Add new dedicated MSBuild property for test TFM for .NET Framework.
- Avoid 4.6.2-specific conditions and instead make them ".NET Framework".
- Add shim to allow using xunit.v3's `TestContext` class to pass `CancellationToken`s to methods under test now.
- Cherry-pick some code analyser fixes from open-telemetry#3867.
- Remove redundant comments.
@martincostello martincostello mentioned this pull request Sep 23, 2026
2 of 4 tasks
@github-actions github-actions Bot added infra Infra work - CI/CD, code coverage, linters comp:dynamiccontrol Things related to OpenTelemetry.DynamicControl comp:extensions.aws Things related to OpenTelemetry.Extensions.AWS comp:persistentstorage.abstractions Things related to OpenTelemetry.PersistentStorage.Abstractions comp:persistentstorage.filesystem Things related to OpenTelemetry.PersistentStorage.FileSystem comp:resources.host Things related to OpenTelemetry.Resources.Host perf Performance related comp:exporter.geneva Things related to OpenTelemetry.Exporter.Geneva comp:exporter.influxdb Things related to OpenTelemetry.Exporter.InfluxDB comp:exporter.onecollector Things related to OpenTelemetry.Exporter.OneCollector labels Sep 23, 2026
@opentelemetry-pr-dashboard

opentelemetry-pr-dashboard Bot commented Sep 23, 2026 •

Copy link
Copy Markdown

Pull request dashboard status

Merged · refreshed 2026-09-23 11:12 UTC

Status above doesn't look right?
  • Anything look wrong? Report it with what you expected; it helps us improve the dashboard.

@github-actions github-actions Bot added comp:extensions Things related to OpenTelemetry.Extensions comp:extensions.enrichment.aspnetcore Things related to OpenTelemetry.Extensions.Enrichment.AspNetCore comp:extensions.enrichment.http Things related to OpenTelemetry.Extensions.Enrichment.Http labels Sep 23, 2026
@github-actions github-actions Bot added comp:extensions.enrichment Things related to OpenTelemetry.Extensions.Enrichment comp:instrumentation.aws Things related to OpenTelemetry.Instrumentation.AWS comp:instrumentation.aspnet.telemetryhttpmodule Things related to OpenTelemetry.Instrumentation.AspNet.TelemetryHttpModule comp:instrumentation.aspnet Things related to OpenTelemetry.Instrumentation.AspNet comp:instrumentation.aspnetcore Things related to OpenTelemetry.Instrumentation.AspNetCore comp:instrumentation.cassandra Things related to OpenTelemetry.Instrumentation.Cassandra comp:instrumentation.confluentkafka Things related to OpenTelemetry.Instrumentation.ConfluentKafka comp:instrumentation.elasticsearchclient Things related to OpenTelemetry.Instrumentation.ElasticsearchClient comp:instrumentation.entityframeworkcore Things related to OpenTelemetry.Instrumentation.EntityFrameworkCore comp:instrumentation.eventcounters Things related to OpenTelemetry.Instrumentation.EventCounters comp:instrumentation.grpccore Things related to OpenTelemetry.Instrumentation.GrpcCore comp:instrumentation.grpcnetclient Things related to OpenTelemetry.Instrumentation.GrpcNetClient comp:instrumentation.hangfire Things related to OpenTelemetry.Instrumentation.Hangfire labels Sep 23, 2026
@github-actions github-actions Bot added comp:instrumentation.http Things related to OpenTelemetry.Instrumentation.Http comp:instrumentation.kusto Things related to OpenTelemetry.Instrumentation.Kusto comp:instrumentation.owin Things related to OpenTelemetry.Instrumentation.Owin comp:instrumentation.process Things related to OpenTelemetry.Instrumentation.Process comp:instrumentation.quartz Things related to OpenTelemetry.Instrumentation.Quartz comp:instrumentation.remoting Things related to OpenTelemetry.Instrumentation.Remoting comp:instrumentation.runtime Things related to OpenTelemetry.Instrumentation.Runtime labels Sep 23, 2026
@codecov

codecov Bot commented Sep 23, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 79.59%. Comparing base (72f7213) to head (73cb315).
✅ All tests successful. No failed tests found.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #5381      +/-   ##
==========================================
- Coverage   79.64%   79.59%   -0.06%     
==========================================
  Files         511      511              
  Lines       21554    21556       +2     
==========================================
- Hits        17167    17157      -10     
- Misses       4387     4399      +12     
Flag Coverage Δ
unittests-Contrib.Shared.Tests 90.40% <ø> (ø)
unittests-DynamicControl 98.70% <ø> (-0.11%) ⬇️
unittests-Exporter.Geneva 56.39% <ø> (ø)
unittests-Exporter.InfluxDB 97.96% <ø> (ø)
unittests-Exporter.OneCollector 95.60% <ø> (ø)
unittests-Extensions 95.77% <ø> (-0.43%) ⬇️
unittests-Extensions.Enrichment 100.00% <ø> (ø)
unittests-Extensions.Enrichment.AspNetCore 86.27% <ø> (ø)
unittests-Extensions.Enrichment.Http 94.33% <ø> (ø)
unittests-Instrumentation.AWS 86.73% <100.00%> (+0.02%) ⬆️
unittests-Instrumentation.AspNet 78.88% <ø> (ø)
unittests-Instrumentation.AspNetCore 88.08% <ø> (ø)
unittests-Instrumentation.Cassandra 94.87% <ø> (+2.56%) ⬆️
unittests-Instrumentation.ConfluentKafka 83.74% <ø> (ø)
unittests-Instrumentation.ElasticsearchClient 80.36% <ø> (ø)
unittests-Instrumentation.EntityFrameworkCore 81.32% <ø> (ø)
unittests-Instrumentation.EventCounters 76.31% <ø> (ø)
unittests-Instrumentation.GrpcCore 91.12% <ø> (ø)
unittests-Instrumentation.GrpcNetClient 80.48% <ø> (ø)
unittests-Instrumentation.Hangfire 88.88% <ø> (ø)
unittests-Instrumentation.Http 79.57% <ø> (ø)
unittests-Instrumentation.Kusto 92.46% <ø> (ø)
unittests-Instrumentation.Owin 89.15% <ø> (ø)
unittests-Instrumentation.Process 100.00% <ø> (ø)
unittests-Instrumentation.Quartz 77.77% <ø> (ø)
unittests-Instrumentation.Remoting 69.26% <ø> (ø)
unittests-Instrumentation.Runtime 100.00% <ø> (ø)
unittests-Instrumentation.ServiceFabricRemoting 38.82% <ø> (ø)
unittests-Instrumentation.SqlClient 86.73% <ø> (ø)
unittests-Instrumentation.StackExchangeRedis 95.95% <ø> (ø)
unittests-Instrumentation.Wcf 83.09% <ø> (ø)
unittests-OpAmp.Client 91.51% <ø> (-0.33%) ⬇️
unittests-PersistentStorage 67.74% <ø> (-1.47%) ⬇️
unittests-PowerShellScripts 86.27% <ø> (ø)
unittests-Resources.AWS 72.88% <ø> (ø)
unittests-Resources.Azure 87.01% <ø> (ø)
unittests-Resources.Container 83.60% <ø> (ø)
unittests-Resources.Gcp 90.09% <ø> (ø)
unittests-Resources.Host 75.29% <100.00%> (ø)
unittests-Resources.OperatingSystem 77.16% <ø> (ø)
unittests-Resources.Process 100.00% <ø> (ø)
unittests-Resources.ProcessRuntime 80.76% <ø> (ø)
unittests-Sampler.AWS 96.05% <ø> (-0.18%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...OpenTelemetry.Extensions.AWS/AWSXRayIdGenerator.cs 59.45% <100.00%> (+1.12%) ⬆️
src/OpenTelemetry.Resources.Host/HostDetector.cs 78.12% <100.00%> (ø)

... and 8 files with indirect coverage changes

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions github-actions Bot added comp:instrumentation.servicefabricremoting Things related to OpenTelemetry.Instrumentation.ServiceFabricRemoting comp:instrumentation.sqlclient Things related to OpenTelemetry.Instrumentation.SqlClient comp:instrumentation.stackexchangeredis Things related to OpenTelemetry.Instrumentation.StackExchangeRedis comp:instrumentation.wcf Things related to OpenTelemetry.Instrumentation.Wcf comp:opamp.client Things related to OpenTelemetry.OpAmp.Client comp:resources.aws Things related to OpenTelemetry.Resources.AWS comp:resources.azure Things related to OpenTelemetry.Resources.Azure comp:resources.gcp Things related to OpenTelemetry.Resources.Gcp comp:resources.operatingsystem Things related to OpenTelemetry.Resources.OperatingSystem comp:resources.process Things related to OpenTelemetry.Resources.Process comp:resources.processruntime Things related to OpenTelemetry.Resources.ProcessRuntime comp:sampler.aws Things related to OpenTelemetry.Samplers.AWS labels Sep 23, 2026
@martincostello
martincostello marked this pull request as ready for review September 23, 2026 08:55
@martincostello
martincostello requested a review from a team as a code owner September 23, 2026 08:55
Copilot AI lite review requested due to automatic review settings September 23, 2026 08:55

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟡 Changes recommended

Moderate findings remain in test correctness and cancellation handling.

Get a fresh assessment by requesting another Copilot review.

Review effort: Lite
Findings: 2 Medium severity · 1 Low severity

Open (3)
What changed in this PR

Prepares the test infrastructure for xUnit v3 by improving cancellation handling, reducing async-test flakiness, and standardizing .NET Framework targeting.

Changes:

  • Adds a shared TestContext cancellation shim.
  • Introduces NetFrameworkVersionForTests and updates framework conditions.
  • Improves test synchronization, cleanup, assertions, and AWS listener management.
File Reviewed changes
test/​Shared/​TestContext.cs Adds the xUnit test cancellation shim.
test/​Shared/​EnabledOnDockerPlatformTheoryAttribute.cs Seals the Docker-platform theory attribute.
test/​Shared/​EnabledOnDockerPlatformFactAttribute.cs Seals the Docker-platform fact attribute.
test/​OpenTelemetry.Sampler.AWS.Tests/​TestRulesCache.cs Updates concurrent operations and assertions.
test/​OpenTelemetry.Sampler.AWS.Tests/​TestRateLimiter.cs Adds cancellation to worker tasks.
test/​OpenTelemetry.Sampler.AWS.Tests/​TestAWSXRaySamplerClient.cs Adds cancellation to client calls.
test/​OpenTelemetry.Sampler.AWS.Tests/​TestAWSXRayRemoteSampler.cs Makes delays cancellation-aware.
test/​OpenTelemetry.Sampler.AWS.Tests/​OpenTelemetry.Sampler.AWS.Tests.csproj Uses the dedicated test TFM property.
test/​OpenTelemetry.Resources.ProcessRuntime.Tests/​OpenTelemetry.Resources.ProcessRuntime.Tests.csproj Uses the dedicated test TFM property.
test/​OpenTelemetry.Resources.Process.Tests/​OpenTelemetry.Resources.Process.Tests.csproj Uses the dedicated test TFM property.
test/​OpenTelemetry.Resources.OperatingSystem.Tests/​OpenTelemetry.Resources.OperatingSystem.Tests.csproj Uses the dedicated test TFM property.
test/​OpenTelemetry.Resources.Host.Tests/​OpenTelemetry.Resources.Host.Tests.csproj Uses the dedicated test TFM property.
test/​OpenTelemetry.Resources.Gcp.Tests/​OpenTelemetry.Resources.Gcp.Tests.csproj Uses the dedicated test TFM property.
test/​OpenTelemetry.Resources.Azure.Tests/​OpenTelemetry.Resources.Azure.Tests.csproj Uses the dedicated test TFM property.
test/​OpenTelemetry.Resources.AWS.Tests/​OpenTelemetry.Resources.AWS.Tests.csproj Uses the dedicated test TFM property.
test/​OpenTelemetry.PersistentStorage.FileSystem.Tests/​OpenTelemetry.PersistentStorage.FileSystem.Tests.csproj Updates .NET Framework conditions.
test/​OpenTelemetry.PersistentStorage.Abstractions.Tests/​OpenTelemetry.PersistentStorage.Abstractions.Tests.csproj Updates .NET Framework conditions.
test/​OpenTelemetry.OpAmp.Client.Tests/​WsTransportTest.cs Adds cancellation and race-resistant waits.
test/​OpenTelemetry.OpAmp.Client.Tests/​Tools/​OpAmpFakeWebSocketServer.cs Adds blocking request-header retrieval.
test/​OpenTelemetry.OpAmp.Client.Tests/​PlainHttpTransportTests.cs Adds cancellation-aware timeout handling.
moderate (1 vote): propagate test cancellation before asserting completion.
test/​OpenTelemetry.OpAmp.Client.Tests/​OpenTelemetry.OpAmp.Client.Tests.csproj Uses the dedicated test TFM property.
test/​OpenTelemetry.OpAmp.Client.Tests/​OpAmpPipeTests.cs Passes cancellation to pipe operations.
test/​OpenTelemetry.OpAmp.Client.Tests/​OpAmpHttpPipeTests.cs Passes cancellation to flush operations.
moderate (1 vote): distinguish xUnit cancellation from a real timeout before throwing.
test/​OpenTelemetry.OpAmp.Client.Tests/​OpAmpClientTests.cs Adds cancellation to client lifecycle tests.
moderate (1 vote): check cancellation after Task.WhenAny before asserting completion.
test/​OpenTelemetry.OpAmp.Client.Tests/​Messages/​EffectiveConfigFileTests.cs Passes cancellation to async parsing.
test/​OpenTelemetry.OpAmp.Client.Tests/​FrameProcessorTests.cs Updates concurrent worker setup.
moderate (1 vote): remove the duplicate subscribe loop or balance it with unsubscribe work.
test/​OpenTelemetry.Instrumentation.Wcf.Tests/​TelemetryPropagationTests.netfx.cs Stabilizes concurrent activity collection.
test/​OpenTelemetry.Instrumentation.Wcf.Tests/​TelemetryDispatchMessageInspectorTests.netfx.cs Adds verifier cancellation.
test/​OpenTelemetry.Instrumentation.Wcf.Tests/​TelemetryDispatchMessageInspectorForOneWayOperationsTests.netfx.cs Adds verifier cancellation.
test/​OpenTelemetry.Instrumentation.Wcf.Tests/​TelemetryBindingElementForTcpTests.netfx.cs Adds verifier and delay cancellation.
test/​OpenTelemetry.Instrumentation.Wcf.Tests/​TelemetryBindingElementForHttpTests.cs Adds verifier cancellation.
test/​OpenTelemetry.Instrumentation.Wcf.Tests/​OpenTelemetry.Instrumentation.Wcf.Tests.csproj Uses the dedicated test TFM property.
test/​OpenTelemetry.Instrumentation.StackExchangeRedis.Tests/​OpenTelemetry.Instrumentation.StackExchangeRedis.Tests.csproj Uses the dedicated test TFM property.
test/​OpenTelemetry.Instrumentation.SqlClient.Tests/​OpenTelemetry.Instrumentation.SqlClient.Tests.csproj Uses the dedicated test TFM property.
test/​OpenTelemetry.Instrumentation.ServiceFabricRemoting.Tests/​OpenTelemetry.Instrumentation.ServiceFabricRemoting.Tests.csproj Uses the dedicated test TFM property.
test/​OpenTelemetry.Instrumentation.Runtime.Tests/​RuntimeMetricsTests.cs Adds cancellation to worker tasks.
test/​OpenTelemetry.Instrumentation.Runtime.Tests/​OpenTelemetry.Instrumentation.Runtime.Tests.csproj Uses the dedicated test TFM property.
test/​OpenTelemetry.Instrumentation.Remoting.Tests/​OpenTelemetry.Instrumentation.Remoting.Tests.csproj Uses the dedicated test TFM property.
test/​OpenTelemetry.Instrumentation.Quartz.Tests/​QuartzDiagnosticListenerTests.cs Adds cancellation to scheduler operations.
test/​OpenTelemetry.Instrumentation.Process.Tests/​ProcessMetricsTests.cs Adds cancellation to concurrent workers.
test/​OpenTelemetry.Instrumentation.Process.Tests/​OpenTelemetry.Instrumentation.Process.Tests.csproj Uses the dedicated test TFM property.
test/​OpenTelemetry.Instrumentation.Owin.Tests/​OpenTelemetry.Instrumentation.Owin.Tests.csproj Uses the dedicated test TFM property.
test/​OpenTelemetry.Instrumentation.Owin.Tests/​DiagnosticsMiddlewareTests.cs Adds cancellation and assertion improvements.
test/​OpenTelemetry.Instrumentation.Kusto.Tests/​OpenTelemetry.Instrumentation.Kusto.Tests.csproj Uses the dedicated test TFM property.
test/​OpenTelemetry.Instrumentation.Kusto.FuzzTests/​OpenTelemetry.Instrumentation.Kusto.FuzzTests.csproj Uses the dedicated test TFM property.
test/​OpenTelemetry.Instrumentation.Http.Tests/​OpenTelemetry.Instrumentation.Http.Tests.csproj Uses the dedicated test TFM property.
test/​OpenTelemetry.Instrumentation.Http.Tests/​HttpWebRequestActivitySourceTests.netfx.cs Adds cancellation to HTTP operations.
test/​OpenTelemetry.Instrumentation.Http.Tests/​HttpClientTests.cs Adds cancellation and assertion improvements.
test/​OpenTelemetry.Instrumentation.Http.Tests/​HttpClientTests.Basic.cs Adds cancellation and assertion improvements.
test/​OpenTelemetry.Instrumentation.Hangfire.Tests/​OpenTelemetry.Instrumentation.Hangfire.Tests.csproj Updates framework conditions.
test/​OpenTelemetry.Instrumentation.GrpcNetClient.Tests/​OpenTelemetry.Instrumentation.GrpcNetClient.Tests.csproj Uses the dedicated test TFM property.
test/​OpenTelemetry.Instrumentation.GrpcNetClient.Tests/​GrpcTests.server.cs Adds cancellation to RPC calls.
test/​OpenTelemetry.Instrumentation.GrpcNetClient.Tests/​GrpcTests.client.cs Adds cancellation to RPC calls.
test/​OpenTelemetry.Instrumentation.GrpcCore.Tests/​OpenTelemetry.Instrumentation.GrpcCore.Tests.csproj Uses the dedicated test TFM property.
test/​OpenTelemetry.Instrumentation.GrpcCore.Tests/​GrpcCoreClientInterceptorTests.cs Adds cancellation to interceptor tests.
moderate (1 vote): pass TestContext.Current.CancellationToken to the stream-write overload.
test/​OpenTelemetry.Instrumentation.EventCounters.Tests/​EventCountersMetricsTests.cs Makes delays cancellation-aware.
test/​OpenTelemetry.Instrumentation.EntityFrameworkCore.Tests/​EntityFrameworkDiagnosticListenerTests.cs Simplifies test data and assertions.
test/​OpenTelemetry.Instrumentation.ElasticsearchClient.Tests/​OpenTelemetry.Instrumentation.ElasticsearchClient.Tests.csproj Uses the dedicated test TFM property.
test/​OpenTelemetry.Instrumentation.ElasticsearchClient.Tests/​ElasticsearchClientTests.cs Adds cancellation and assertion improvements.
test/​OpenTelemetry.Instrumentation.ConfluentKafka.Tests/​OpenTelemetry.Instrumentation.ConfluentKafka.Tests.csproj Uses the dedicated test TFM property.
test/​OpenTelemetry.Instrumentation.ConfluentKafka.Tests/​InstrumentedProducerTests.cs Adds cancellation to producer calls.
test/​OpenTelemetry.Instrumentation.Cassandra.Tests/​OpenTelemetry.Instrumentation.Cassandra.Tests.csproj Uses the dedicated test TFM property.
test/​OpenTelemetry.Instrumentation.Cassandra.Tests/​CassandraInstrumentationTests.cs Disposes clusters and updates metric checks.
moderate (3 votes): retain a sorted exact metric-set comparison instead of only Contains assertions.
test/​OpenTelemetry.Instrumentation.AWS.Tests/​TestAWSClientMetricsInstrumentation.cs Adds cancellation and assertion improvements.
test/​OpenTelemetry.Instrumentation.AWS.Tests/​TestAWSClientInstrumentation.cs Adds cancellation and registry cleanup.
test/​OpenTelemetry.Instrumentation.AWS.Tests/​OpenTelemetry.Instrumentation.AWS.Tests.csproj Configures the dedicated test framework target.
test/​OpenTelemetry.Instrumentation.AWS.Tests/​AWSClientInstrumentationOptionsTests.cs Adds collection synchronization metadata.
moderate (2 votes): use a separate public [CollectionDefinition] type and keep [Collection] on the test class.
test/​OpenTelemetry.Instrumentation.AspNetCore.Tests/​RouteTests/​RoutingTestFixture.cs Simplifies helper methods.
test/​OpenTelemetry.Instrumentation.AspNetCore.Tests/​MetricTests.cs Adds cancellation to HTTP and delay operations.
test/​OpenTelemetry.Instrumentation.AspNetCore.Tests/​IncomingRequestsCollectionsIsAccordingToTheSpecTests.cs Adds cancellation and assertion improvements.
test/​OpenTelemetry.Instrumentation.AspNetCore.Tests/​EndToEndTests.cs Adds request cancellation.
test/​OpenTelemetry.Instrumentation.AspNetCore.Tests/​BasicTests.cs Improves factory cleanup and synchronization.
test/​OpenTelemetry.Instrumentation.AspNet.Tests/​OpenTelemetry.Instrumentation.AspNet.Tests.csproj Uses the dedicated test TFM property.
test/​OpenTelemetry.Instrumentation.AspNet.Tests/​HttpInMetricsListenerTests.cs Adds cancellation to worker tasks.
test/​OpenTelemetry.Instrumentation.AspNet.TelemetryHttpModule.Tests/​OpenTelemetry.Instrumentation.AspNet.TelemetryHttpModule.Tests.csproj Uses the dedicated test TFM property.
test/​OpenTelemetry.Instrumentation.AspNet.TelemetryHttpModule.Tests/​ActivityHelperTest.cs Adds cancellation to background tasks.
test/​OpenTelemetry.Extensions.Tests/​Trace/​RateLimitingSamplerTests.cs Makes delays cancellation-aware.
test/​OpenTelemetry.Extensions.Tests/​OpenTelemetry.Extensions.Tests.csproj Uses the dedicated test TFM property.
test/​OpenTelemetry.Extensions.FuzzTests/​OpenTelemetry.Extensions.FuzzTests.csproj Uses the dedicated test TFM property.
test/​OpenTelemetry.Extensions.Enrichment.Tests/​OpenTelemetryEnrichmentServiceCollectionExtensionsTests.cs Adds cancellation and assertion improvements.
test/​OpenTelemetry.Extensions.Enrichment.Tests/​OpenTelemetry.Extensions.Enrichment.Tests.csproj Uses the dedicated test TFM property.
test/​OpenTelemetry.Extensions.Enrichment.Http.Tests/​OpenTelemetry.Extensions.Enrichment.Http.Tests.csproj Uses the dedicated test TFM property.
test/​OpenTelemetry.Extensions.Enrichment.Http.Tests/​HttpClientTraceEnrichmentAcceptanceTests.cs Adds request cancellation.
test/​OpenTelemetry.Extensions.Enrichment.AspNetCore.Tests/​EnrichmentTests.cs Simplifies wait helpers and assertions.
test/​OpenTelemetry.Extensions.Benchmarks/​OpenTelemetry.Extensions.Benchmarks.csproj Uses the dedicated test TFM property.
test/​OpenTelemetry.Extensions.AWS.Tests/​OpenTelemetry.Extensions.AWS.Tests.csproj Uses the dedicated test TFM property.
test/​OpenTelemetry.Extensions.AWS.Tests/​AWSXRayIdGeneratorTests.cs Disposes test activities.
test/​OpenTelemetry.Exporter.OneCollector.Tests/​OpenTelemetry.Exporter.OneCollector.Tests.csproj Removes a redundant framework comment.
test/​OpenTelemetry.Exporter.OneCollector.Benchmarks/​OpenTelemetry.Exporter.OneCollector.Benchmarks.csproj Updates benchmark framework targeting.
test/​OpenTelemetry.Exporter.InfluxDB.Tests/​OpenTelemetry.Exporter.InfluxDB.Tests.csproj Updates .NET Framework conditions.
test/​OpenTelemetry.Exporter.Geneva.Tests/​MessagePackSerializerTests.cs Adds cancellation to deserialization.
test/​OpenTelemetry.Exporter.Geneva.Tests/​GenevaTraceExporterTests.cs Adds cancellation to deserialization.
test/​OpenTelemetry.Exporter.Geneva.Tests/​GenevaLogExporterTests.cs Adds cancellation and assertion improvements.
test/​OpenTelemetry.Exporter.Geneva.Tests/​GenevaLogExporterAFDCorrelationTests.cs Adds cancellation and assertion improvements.
test/​OpenTelemetry.DynamicControl.Tests/​PolicyStoreConcurrencyTests.cs Adds cancellation to concurrent operations.
test/​OpenTelemetry.DynamicControl.Tests/​PolicyCoordinatorTests.cs Adds cancellation to refresh operations.
test/​OpenTelemetry.DynamicControl.Tests/​PolicyCoordinatorIntegrationTests.cs Adds cancellation to refresh operations.
test/​OpenTelemetry.DynamicControl.Tests/​PolicyChangeSubscriptionTests.cs Adds cancellation to waits and delays.
test/​OpenTelemetry.DynamicControl.Tests/​OpenTelemetry.DynamicControl.Tests.csproj Uses the dedicated test TFM property.
test/​OpenTelemetry.DynamicControl.FuzzTests/​OpenTelemetry.DynamicControl.FuzzTests.csproj Uses the dedicated test TFM property.
test/​OpenTelemetry.Contrib.Shared.Tests/​SqlProcessorTestCases.cs Makes test-case construction explicit.
test/​OpenTelemetry.Contrib.Shared.Tests/​OpenTelemetry.Contrib.Shared.Tests.csproj Updates framework conditions.
test/​OpenTelemetry.Contrib.Shared.FuzzTests/​OpenTelemetry.Contrib.Shared.FuzzTests.csproj Uses the dedicated test TFM property.
test/​OpenTelemetry.Contrib.Shared.Benchmarks/​OpenTelemetry.Contrib.Shared.Benchmarks.csproj Uses the dedicated test TFM property.
src/​OpenTelemetry.Resources.Host/​HostDetector.cs Uses collection-expression syntax.
src/​OpenTelemetry.PersistentStorage.FileSystem/​OpenTelemetry.PersistentStorage.FileSystem.csproj Updates .NET Framework conditions.
src/​OpenTelemetry.PersistentStorage.Abstractions/​OpenTelemetry.PersistentStorage.Abstractions.csproj Updates .NET Framework conditions.
src/​OpenTelemetry.Extensions.AWS/​AWSXRayIdGenerator.cs Manages global listener lifetime.
nit (2 votes): document the listener-lifetime/runtime fix in the component changelog.
src/​OpenTelemetry.DynamicControl/​OpenTelemetry.DynamicControl.csproj Updates .NET Framework conditions.
build/​Common.props Defines the dedicated test framework property.
build/​Common.nonprod.props Links the shared test-context shim into test projects.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread src/OpenTelemetry.Extensions.AWS/AWSXRayIdGenerator.cs
@martincostello
martincostello added this pull request to the merge queue Sep 23, 2026
Merged via the queue into open-telemetry:main with commit d253bc5 Sep 23, 2026
323 checks passed
@martincostello
martincostello deleted the xunit-v3-prep branch September 23, 2026 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp:dynamiccontrol Things related to OpenTelemetry.DynamicControl comp:exporter.geneva Things related to OpenTelemetry.Exporter.Geneva comp:exporter.influxdb Things related to OpenTelemetry.Exporter.InfluxDB comp:exporter.onecollector Things related to OpenTelemetry.Exporter.OneCollector comp:extensions.aws Things related to OpenTelemetry.Extensions.AWS comp:extensions.enrichment.aspnetcore Things related to OpenTelemetry.Extensions.Enrichment.AspNetCore comp:extensions.enrichment.http Things related to OpenTelemetry.Extensions.Enrichment.Http comp:extensions.enrichment Things related to OpenTelemetry.Extensions.Enrichment comp:extensions Things related to OpenTelemetry.Extensions comp:instrumentation.aspnet.telemetryhttpmodule Things related to OpenTelemetry.Instrumentation.AspNet.TelemetryHttpModule comp:instrumentation.aspnet Things related to OpenTelemetry.Instrumentation.AspNet comp:instrumentation.aspnetcore Things related to OpenTelemetry.Instrumentation.AspNetCore comp:instrumentation.aws Things related to OpenTelemetry.Instrumentation.AWS comp:instrumentation.cassandra Things related to OpenTelemetry.Instrumentation.Cassandra comp:instrumentation.confluentkafka Things related to OpenTelemetry.Instrumentation.ConfluentKafka comp:instrumentation.elasticsearchclient Things related to OpenTelemetry.Instrumentation.ElasticsearchClient comp:instrumentation.entityframeworkcore Things related to OpenTelemetry.Instrumentation.EntityFrameworkCore comp:instrumentation.eventcounters Things related to OpenTelemetry.Instrumentation.EventCounters comp:instrumentation.grpccore Things related to OpenTelemetry.Instrumentation.GrpcCore comp:instrumentation.grpcnetclient Things related to OpenTelemetry.Instrumentation.GrpcNetClient comp:instrumentation.hangfire Things related to OpenTelemetry.Instrumentation.Hangfire comp:instrumentation.http Things related to OpenTelemetry.Instrumentation.Http comp:instrumentation.kusto Things related to OpenTelemetry.Instrumentation.Kusto comp:instrumentation.owin Things related to OpenTelemetry.Instrumentation.Owin comp:instrumentation.process Things related to OpenTelemetry.Instrumentation.Process comp:instrumentation.quartz Things related to OpenTelemetry.Instrumentation.Quartz comp:instrumentation.remoting Things related to OpenTelemetry.Instrumentation.Remoting comp:instrumentation.runtime Things related to OpenTelemetry.Instrumentation.Runtime comp:instrumentation.servicefabricremoting Things related to OpenTelemetry.Instrumentation.ServiceFabricRemoting comp:instrumentation.sqlclient Things related to OpenTelemetry.Instrumentation.SqlClient comp:instrumentation.stackexchangeredis Things related to OpenTelemetry.Instrumentation.StackExchangeRedis comp:instrumentation.wcf Things related to OpenTelemetry.Instrumentation.Wcf comp:opamp.client Things related to OpenTelemetry.OpAmp.Client comp:persistentstorage.abstractions Things related to OpenTelemetry.PersistentStorage.Abstractions comp:persistentstorage.filesystem Things related to OpenTelemetry.PersistentStorage.FileSystem comp:resources.aws Things related to OpenTelemetry.Resources.AWS comp:resources.azure Things related to OpenTelemetry.Resources.Azure comp:resources.gcp Things related to OpenTelemetry.Resources.Gcp comp:resources.host Things related to OpenTelemetry.Resources.Host comp:resources.operatingsystem Things related to OpenTelemetry.Resources.OperatingSystem comp:resources.process Things related to OpenTelemetry.Resources.Process comp:resources.processruntime Things related to OpenTelemetry.Resources.ProcessRuntime comp:sampler.aws Things related to OpenTelemetry.Samplers.AWS infra Infra work - CI/CD, code coverage, linters perf Performance related

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants