[Dynamic Control] Phase 5b: Add policy parsers - #5213
Merged
martincostello merged 4 commits intoSep 17, 2026
Merged
martincostello merged 4 commits into
martincostello merged 4 commits into
Conversation
7 of 15 tasks
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5213 +/- ##
==========================================
+ Coverage 79.25% 79.42% +0.17%
==========================================
Files 500 504 +4
Lines 21023 21204 +181
==========================================
+ Hits 16661 16841 +180
- Misses 4362 4363 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
stevejgordon
force-pushed
the
dynamic-control-phase-5-parser
branch
from
September 15, 2026 15:46
460600c to
66da402
Compare
stevejgordon
marked this pull request as ready for review
September 16, 2026 05:21
Pull request dashboard statusMerged · refreshed 2026-09-17 14:51 UTC Status above doesn't look right?
|
martincostello
approved these changes
Sep 17, 2026
| INSER = "INSER" | ||
| SELEC = "SELEC" | ||
| UPDAT = "UPDAT" | ||
| probabilit = "probabilit" |
Member
There was a problem hiding this comment.
Why do we need this intentional typo?
Contributor
Author
There was a problem hiding this comment.
It's used in JsonKeyValuePolicyParserTests for some of the malformed and escaped tests.
Member
There was a problem hiding this comment.
Cool - I couldn't immediately see it in a Ctrl+F other than here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contributes to: #4742
Changes
Adds an internal JSON parser that decodes a complete JSON policy payload into validated policy models.
Merge requirement checklist
CHANGELOG.mdfiles updated for non-trivial changesChanges in public API reviewed (if applicable)