[Infra] .NET 11 preparation - #5207
Merged
martincostello merged 1 commit intoSep 14, 2026
Merged
Conversation
Cherry-pick fixes for new code analysis warnings from open-telemetry#3867.
martincostello
marked this pull request as ready for review
September 12, 2026 11:59
martincostello
enabled auto-merge
September 12, 2026 11:59
Pull request dashboard statusMerged · refreshed 2026-09-14 13:40 UTC Status above doesn't look right?
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5207 +/- ##
=======================================
Coverage 79.24% 79.24%
=======================================
Files 500 500
Lines 21023 21023
=======================================
Hits 16659 16659
Misses 4364 4364
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The reviewed changes address .NET 11 warnings without identified blocking issues.
Pull request overview
Prepares test code for .NET 11 analyzer and nullability changes without altering production behavior.
Changes:
- Handles framework-specific event payload nullability.
- Simplifies exception and lambda expressions.
- Refactors HTTP metric filtering and assertions.
File summaries
| File | Description |
|---|---|
test/OpenTelemetry.Resources.Azure.Tests/AzureResourceDetectorTests.cs |
Handles payload nullability across target frameworks. |
test/OpenTelemetry.Instrumentation.ServiceFabricRemoting.Tests/ServiceFabricRemotingTests.cs |
Simplifies nullable exception syntax. |
test/OpenTelemetry.Instrumentation.Http.Tests/HttpClientTests.cs |
Refactors metric filtering and expected counts. |
test/OpenTelemetry.Instrumentation.AWSLambda.Tests/AWSLambdaWrapperTests.cs |
Simplifies lambda parameter declarations. |
Review details
- Files reviewed: 4/4 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Kielek
approved these changes
Sep 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Cherry-pick fixes for new code analysis warnings from #3867.
Merge requirement checklist
AppropriateCHANGELOG.mdfiles updated for non-trivial changesChanges in public API reviewed (if applicable)