Sitelet https://github.com/ooni/probe-cli/pull/1799
Skip to content

adding tcp traceroute capabilities to Feature/tlsmiddleboxprobe - #1799

Open
snourin wants to merge 38 commits into
masterfrom
feature/tlsmiddleboxprobe
Open

adding tcp traceroute capabilities to Feature/tlsmiddleboxprobe#1799
snourin wants to merge 38 commits into
masterfrom
feature/tlsmiddleboxprobe

Conversation

@snourin

@snourin snourin commented Jul 24, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Checklist

  • I have read the contribution guidelines
  • reference issue for this pull request:
  • if you changed anything related to how experiments work and you need to reflect these changes in the ooni/spec repository, please link to the related ooni/spec pull request: (adding icmp data format spec#308)
  • if you changed code inside an experiment, make sure you bump its version number

Description

PR for the tlsmiddlebox probe using TCP traceroute. Timestamps have been added. Will continue cleaning up the code.

@snourin
snourin requested review from DecFox and hellais as code owners July 24, 2026 09:13
@snourin snourin self-assigned this Jul 24, 2026
@snourin snourin mentioned this pull request Jul 24, 2026
Open
3 of 4 tasks
@munzzyy

munzzyy commented Aug 1, 2026

Copy link
Copy Markdown
Contributor

tcp_traceroute_probe.go has no build constraint, so it lands in every platform build. On 013d579:

$ GOOS=windows GOARCH=amd64 go build ./internal/experiment/tlsmiddlebox/
tcp_traceroute_probe.go:46:18: undefined: unix.Socket
tcp_traceroute_probe.go:54:57: undefined: unix.IP_RECVERR

$ GOOS=darwin GOARCH=arm64 go build ./internal/experiment/tlsmiddlebox/
tcp_traceroute_probe.go:54:57: undefined: unix.IP_RECVERR
tcp_traceroute_probe.go:70:57: undefined: unix.SO_TIMESTAMPING

Both are clean on master. PR CI misses it because windows.yml and macos.yml only fire on release branches and the nightly cron. The package already splits by platform in syscall_unix.go / syscall_windows.go / syscall_otherwise.go, so probeTCP could follow that shape.

Also lines 149 and 160-161 print the raw quote to stdout mid-measurement. Leftover from debugging?

@snourin
snourin force-pushed the feature/tlsmiddleboxprobe branch from 2fc9db7 to 4795168 Compare September 23, 2026 21:03
DecFox
DecFox requested changes Sep 30, 2026
View reviewed changes

@DecFox DecFox left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes. I left a few remarks. The general principle we tend to follow is to have some kind of function level comment for each function we have which shortly describes what that function does (as a short doc). I think the new functions in this diff do no do that and it would be nice if we can have those.

Comment thread internal/experiment/tlsmiddlebox/unix_ops.go
Comment thread internal/experiment/tlsmiddlebox/tcp_traceroute_test.go
Comment thread internal/experiment/tlsmiddlebox/dialer_unix.go
Comment thread internal/model/archival.go Outdated
Comment thread internal/model/archival.go Outdated
DecFox
DecFox requested changes Sep 30, 2026
View reviewed changes
Comment thread internal/registry/tlsmiddlebox.go
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@DecFox DecFox DecFox requested changes
@hellais hellais Awaiting requested review from hellais hellais is a code owner

Assignees

@snourin snourin

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@snourin @munzzyy @DecFox