Sitelet https://github.com/o3de/o3de/pull/20171
Skip to content

[3rdParty] vulkan-memory-allocator v3.4.0 - #20171

Open
EnterTheArcane wants to merge 1 commit into
o3de:developmentfrom
EnterTheArcane:3rdparty-vulkan-memory-allocator
Open

EnterTheArcane wants to merge 1 commit into
o3de:developmentfrom
EnterTheArcane:3rdparty-vulkan-memory-allocator

Conversation

@EnterTheArcane

Copy link
Copy Markdown
Contributor

What does this PR do?

Adds Vulkan Memory Allocator v3.4.0 as the FetchContent-backed 3rdParty::vulkan-memory-allocator target.

Replaces Atom Vulkan's bundled VMA 3.1.0 copy and Findamd_vma.cmake, updates includes to the upstream layout, and lists the upstream natvis file as a target source.

Lets VMA resolve Vulkan functions through Glad's proc-address functions.

Signed-off-by: EnterTheArcane <96613937+EnterTheArcane@users.noreply.github.com>
@rossbridger

Copy link
Copy Markdown
Contributor

I have an earlier work on vma update on #20057, should I close it in favor of your PR?

@EnterTheArcane

Copy link
Copy Markdown
Contributor Author

I have an earlier work on vma update on #20057, should I close it in favor of your PR?

Oh nice! I didn't mean to step on work you had already done. This is just something I had planned as part of a migration from GLAD to Volk.

It might make sense to close 20057 in favor of this if they do the same thing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants