23.10.3 Point Release - #17852
Merged
Merged
23.10.3 Point Release#17852
Conversation
* handle dynamic container elements (#17411) Signed-off-by: Alex Montgomery <alexmont@amazon.com> * re-enable recycling, esp for prefab override labels (#17343) * re-enable recycling, esp for prefab override labels Signed-off-by: Alex Montgomery <alexmont@amazon.com> * addressed PR feedback Signed-off-by: Alex Montgomery <alexmont@amazon.com> * forcing immediate deletion to satisfy tests Signed-off-by: Alex Montgomery <alexmont@amazon.com> * try Qt's shared pointers instead Signed-off-by: Alex Montgomery <alexmont@amazon.com> --------- Signed-off-by: Alex Montgomery <alexmont@amazon.com> * fix element add for containers with DynamicElementType (#17441) * handle dynamic container elements Signed-off-by: Alex Montgomery <alexmont@amazon.com> * not quite working dynamic add Signed-off-by: Alex Montgomery <alexmont@amazon.com> * container dynamic add works Signed-off-by: Alex Montgomery <alexmont@amazon.com> --------- Signed-off-by: Alex Montgomery <alexmont@amazon.com> * Handle ClassElement::FLG_POINTER in DPE-based Inspector (#17457) * handle dynamic container elements Signed-off-by: Alex Montgomery <alexmont@amazon.com> * not quite working dynamic add Signed-off-by: Alex Montgomery <alexmont@amazon.com> * container dynamic add works Signed-off-by: Alex Montgomery <alexmont@amazon.com> * implemented baseclass container element addition Signed-off-by: Alex Montgomery <alexmont@amazon.com> * Update Code/Framework/AzFramework/AzFramework/DocumentPropertyEditor/ReflectionAdapter.cpp Co-authored-by: Alex Peterson <26804013+AMZN-alexpete@users.noreply.github.com> Signed-off-by: Alex Montgomery <alexmont@amazon.com> --------- Signed-off-by: Alex Montgomery <alexmont@amazon.com> Co-authored-by: Alex Peterson <26804013+AMZN-alexpete@users.noreply.github.com> * Speed up DPE's color picker handling by 2-3x and disallow redundant updates (#17493) * queue refresh in singleshot to keep it from happening more than once a loop Signed-off-by: Alex Montgomery <alexmont@amazon.com> * doubled the color picker performance Signed-off-by: Alex Montgomery <alexmont@amazon.com> --------- Signed-off-by: Alex Montgomery <alexmont@amazon.com> * added recycling capability to several common handlers (#17512) Signed-off-by: Alex Montgomery <alexmont@amazon.com> * fix unused assert Signed-off-by: Alex Montgomery <alexmont@amazon.com> --------- Signed-off-by: Alex Montgomery <alexmont@amazon.com> Co-authored-by: Alex Peterson <26804013+AMZN-alexpete@users.noreply.github.com>
Signed-off-by: Danilo Aimini <82231674+AMZN-daimini@users.noreply.github.com>
Signed-off-by: Danilo Aimini <82231674+AMZN-daimini@users.noreply.github.com>
… with the DPE's size detection code. Signed-off-by: Danilo Aimini <82231674+AMZN-daimini@users.noreply.github.com>
Signed-off-by: Danilo Aimini <82231674+AMZN-daimini@users.noreply.github.com>
Signed-off-by: Danilo Aimini <82231674+AMZN-daimini@users.noreply.github.com>
Signed-off-by: Danilo Aimini <82231674+AMZN-daimini@users.noreply.github.com>
Signed-off-by: Danilo Aimini <82231674+AMZN-daimini@users.noreply.github.com>
Signed-off-by: Danilo Aimini <82231674+AMZN-daimini@users.noreply.github.com>
…opertyEditor/DocumentPropertyEditor.cpp Co-authored-by: Steve Pham <82231385+spham-amzn@users.noreply.github.com> Signed-off-by: Alex Montgomery <alexmont@amazon.com>
…opertyEditor/ContainerActionButtonHandler.cpp Co-authored-by: Steve Pham <82231385+spham-amzn@users.noreply.github.com> Signed-off-by: Alex Montgomery <alexmont@amazon.com>
…r in a Unit Test and handle deletion differently. Signed-off-by: Danilo Aimini <82231674+AMZN-daimini@users.noreply.github.com>
Signed-off-by: Danilo Aimini <82231674+AMZN-daimini@users.noreply.github.com>
…rryPick Cherry-pick DPE fixes to point-release 23.10.3
… that the changes can be picked up by the level saving mechanism. Signed-off-by: Danilo Aimini <82231674+AMZN-daimini@users.noreply.github.com>
…17543 Ensure Collider widgets correctly signal when they're being edited
Signed-off-by: Danilo Aimini <82231674+AMZN-daimini@users.noreply.github.com>
Signed-off-by: Danilo Aimini <82231674+AMZN-daimini@users.noreply.github.com>
…plashFix Fix the proportions of the Editor splashscreen for 23.10.3
Signed-off-by: Danilo Aimini <82231674+AMZN-daimini@users.noreply.github.com>
…y Editors Signed-off-by: lumberyard-employee-dm <56135373+lumberyard-employee-dm@users.noreply.github.com>
Signed-off-by: Danilo Aimini <82231674+AMZN-daimini@users.noreply.github.com>
…17718 [Cherry-Pick] DPE | Prevent crash on multi-edit when back of the patch is not an index.
…peAggregateFix [Cherry-pick] fix to ChangeValidate functions not triggering in Property Editors.
Signed-off-by: Danilo Aimini <82231674+AMZN-daimini@users.noreply.github.com>
…ggered, which can be used by actions to retrieve the click position at the time of user interaction for their purposes. Signed-off-by: Danilo Aimini <82231674+AMZN-daimini@users.noreply.github.com>
Signed-off-by: Danilo Aimini <82231674+AMZN-daimini@users.noreply.github.com>
… to take the interaction point into account and create/spawn at position if needed. Signed-off-by: Danilo Aimini <82231674+AMZN-daimini@users.noreply.github.com>
Signed-off-by: Danilo Aimini <82231674+AMZN-daimini@users.noreply.github.com>
…ing through container entities, and just allow you to select an entity directly in the viewport. Signed-off-by: Danilo Aimini <82231674+AMZN-daimini@users.noreply.github.com>
Signed-off-by: Mike Chang <changml@amazon.com>
…fore failed changes in subsequent syncs (#17847) Signed-off-by: Steve Pham <82231385+spham-amzn@users.noreply.github.com>
Contributor
|
Would it be possible to add #17853 once ready? |
Contributor
Author
Yes, it may take some time to re-run AR tho, especially if we get a flaky failure... |
nick-l-o3de
approved these changes
Apr 29, 2024
nick-l-o3de
left a comment
Contributor
There was a problem hiding this comment.
It looks like the cherrypick of all of those to me. Hard to verify though.
spham-amzn
approved these changes
Apr 29, 2024
forkercat
approved these changes
Apr 29, 2024
Contributor
|
Once this one submits, its going to need it too |
* Fixes crash when full refreshing AssetProcessor Also fixes a crash when deleting elements out of the file system Also fixes a crash when clicking on thumbnails while they are generating. Signed-off-by: Nicholas Lawson <70027408+nick-l-o3de@users.noreply.github.com> * Update Code/Framework/AzToolsFramework/AzToolsFramework/AssetBrowser/AssetBrowserComponent.cpp Co-authored-by: Steve Pham <82231385+spham-amzn@users.noreply.github.com> Signed-off-by: Nicholas Lawson <70027408+nick-l-o3de@users.noreply.github.com> --------- Signed-off-by: Nicholas Lawson <70027408+nick-l-o3de@users.noreply.github.com> Co-authored-by: Steve Pham <82231385+spham-amzn@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Merges the
23.10.3release intomain.