Repository navigation
Use exception convenience methods - #5982
Merged
roji merged 5 commits intoDec 28, 2024
Merged
Conversation
dvas-hash
pushed a commit
to dvas-hash/npgsql
that referenced
this pull request
Jan 17, 2025
This was referenced Nov 23, 2025
This was referenced Sep 15, 2026
Bump the dotnet-dependencies group with 8 updates
SaiTejaReddyYeldandi/CSharp_RiskFeed_Automation#10
Closed
This was referenced Sep 23, 2026
Bump the dotnet-dependencies group with 8 updates
SaiTejaReddyYeldandi/CSharp_RiskFeed_Automation#11
Closed
This was referenced Sep 30, 2026
Bump the dotnet-dependencies group with 9 updates
SaiTejaReddyYeldandi/CSharp_RiskFeed_Automation#12
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use the built-in .net exception convenience methods where they make sense. Contributes to #2237
Converted most of the Parameter exceptions to convenience methods or the helper class.
Some observable changes:
NpgsqlRawCopyStream.ValidateArguments can throw ArgumentOutOfRangeException.
PgWriter.Write can throw ArgumentOutOfRangeException.
NpgsqlConnectionStringBuilder.HostRecheckSeconds now throws ArgumentOutOfRangeException.
ObjectDisposedException will use the type's FullName instead of a mix of class name and full name.
ArgumentException.ThrowIfNullOrEmpty/ThrowIfNullOrWhiteSpace will throw a ArgumentNullException if the value is null or just the ArgumentException base class if the value is empty.
Some exception messages are now just using the defaults. Left anything that looked meaningful or provided extra context.