Repository navigation
Add SslMode.Allow, VerifyCA and VerifyFull - #4005
Merged
Merged
Conversation
vonzshik
force-pushed
the
ssl-validation-rewrite
branch
10 times, most recently
from
October 3, 2021 21:25
c2dca8b to
8830e77
Compare
vonzshik
force-pushed
the
ssl-validation-rewrite
branch
from
October 3, 2021 21:30
8830e77 to
ef00bcd
Compare
roji
requested changes
Oct 4, 2021
roji
left a comment
Member
There was a problem hiding this comment.
Here you go @vonzshik. Looks good, but I think it does an earlier state of the discussion - in the end I think we agreed to require TSC=true when SslMode=Require (and not allow TSC=false). I think this means we don't need to make TSC nullable.
Just out of the curiosity, why did the self-signed certificate/key under .build need to be replaced?
/cc @NinoFloris
vonzshik
force-pushed
the
ssl-validation-rewrite
branch
from
October 4, 2021 09:27
03ab21e to
142594c
Compare
vonzshik
force-pushed
the
ssl-validation-rewrite
branch
from
October 4, 2021 10:00
b790bab to
82983e1
Compare
roji
approved these changes
Oct 4, 2021
roji
left a comment
Member
There was a problem hiding this comment.
Just one last thing we forgot - can merge directly after fixing.
roji
approved these changes
Oct 4, 2021
baal2000
reviewed
May 4, 2022
baal2000
left a comment
Contributor
There was a problem hiding this comment.
One small comment for NpgsqlConnectionStringBuilder.Generated.cs that I may or may not be an "issue".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #3684
Closes #3652
Closes #3988
Closes #4008