added define to build without streams - #42
Merged
Merged
Conversation
Collaborator
|
Hi @theShmoo , Thanks for your input. I'll likely implement these changes myself and perhaps use a configuration flag like Files to update:
|
Contributor
Author
|
Thanks! Can I help you with anything? |
Collaborator
|
Sure, if you like to update this PR into the direction of the suggestion above, that would certainly be of help :) |
nssv_NO_STREAM to nssv_CONFIG_NO_STREAM_INSERTION
Contributor
Author
|
I updated the requested files 👍 |
Collaborator
|
Thanks @theShmoo , Looks good... However, there's something I forgot to warn for: trailing double spaces in Thanks for your help. |
Contributor
Author
|
Will do! Sorry for the auto formatting. Forgot to deactivate.
Martin Moene ***@***.***> schrieb am Sa., 24. Apr. 2021,
14:01:
… Thanks @theShmoo <https://github.com/theShmoo> ,
Looks good...
However, there's something I forgot to warn for: trailing double spaces in
README.md's markdown are significant (see .editorconfig
<https://github.com/martinmoene/string-view-lite/blob/2abb8ead9c51a28c087109ef842754bc52537001/.editorconfig#L15>)
and there are quite a lot of them. I'd appreciate it if you could you
revert those to as they were before.
Thanks for your help.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#42 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABK7ANZZ7BJ5NT526JNRZNTTKKXKLANCNFSM43OOXAYQ>
.
|
Contributor
Author
|
Thank you very much for your support! |
Collaborator
|
You're welcome, thank you too :) |
martinmoene
added a commit
that referenced
this pull request
Apr 26, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello! Thanks for your great library.
I need to use your library in an Intel SGX Enclave where we can't use standard streams (for security reasons).
In order to use your library I needed to exclude those lines from the header