Non-recursive variant of detail::length() for compilers with maximum recursion depth in compile-time constexpr evaluation. - #29
Merged
martinmoene merged 1 commit intoJan 25, 2020
Conversation
…recursion depth in compile-time constexpr evaluation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I ran into this in C++14 when creating a string_view with a very long string. For example,
On MSVC 2019 in C++14 mode this gives:
And on g++ 9.2.1 this gives
I don't think we can fix this for C++11, but when we have C++14 we have better ways to write a constexpr length() of a nullterminated string, so might as well do so to work around this problem.