Sitelet https://github.com/nodejs/node/pull/54790/commits/3ae1ea04e561a95fbd96d6f1e721a9191417e985
Skip to content

tls: add allowPartialTrustChain flag #54790

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
addaleax wants to merge 6 commits into from
Closed

tls: add allowPartialTrustChain flag #54790

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
bb69f14
tls: add `allowPartialTrustChain` flag
addaleax Sep 5, 2024
d488340
fixup! tls: add `allowPartialTrustChain` flag
addaleax Sep 5, 2024
5f501b4
fixup! fixup! tls: add `allowPartialTrustChain` flag
addaleax Sep 5, 2024
509156a
fixup! tls: add `allowPartialTrustChain` flag
addaleax Sep 5, 2024
433f6b3
fixup! fixup! tls: add `allowPartialTrustChain` flag
addaleax Sep 5, 2024
3ae1ea0
fixup! fixup! fixup! tls: add `allowPartialTrustChain` flag
addaleax Sep 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fixup! fixup! fixup! tls: add allowPartialTrustChain flag
  • Loading branch information
@addaleax
addaleax committed Sep 5, 2024
commit 3ae1ea04e561a95fbd96d6f1e721a9191417e985
1 change: 1 addition & 0 deletions src/crypto/crypto_context.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -756,6 +756,7 @@ void SecureContext::SetCert(const FunctionCallbackInfo<Value>& args) {
USE(sc->AddCert(env, std::move(bio)));
}

// NOLINTNEXTLINE(runtime/int)
void SecureContext::SetX509StoreFlag(unsigned long flags) {
X509_STORE* cert_store = GetCertStoreOwnedByThisSecureContext();
CHECK_EQ(1, X509_STORE_set_flags(cert_store, flags));
Expand Down
2 changes: 1 addition & 1 deletion src/crypto/crypto_context.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ class SecureContext final : public BaseObject {
void SetCACert(const BIOPointer& bio);
void SetRootCerts();

void SetX509StoreFlag(unsigned long flags);
void SetX509StoreFlag(unsigned long flags); // NOLINT(runtime/int)
X509_STORE* GetCertStoreOwnedByThisSecureContext();

// TODO(joyeecheung): track the memory used by OpenSSL types
Expand Down