Sitelet https://github.com/nodejs/node/pull/52260/commits/5ff73f3a3abf17d0ba7207c2085f31dd38165653
Skip to content

[v20.x backport] test_runner: format coverage report for tap reporter #52260

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
atlowChemi wants to merge 3 commits into from
Closed

[v20.x backport] test_runner: format coverage report for tap reporter #52260

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1daccf5
perf_hooks: reduce overhead of createHistogram
H4ad Oct 6, 2023
5ff73f3
test: avoid v8 deadcode on performance function
H4ad Oct 18, 2023
d2ac2e4
test_runner: format coverage report for tap reporter
pulkit-30 Dec 15, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
test: avoid v8 deadcode on performance function 
PR-URL: #50074
Backport-PR-URL: #51306
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
  • Loading branch information
@H4ad @richardlau
H4ad authored and richardlau committed Mar 28, 2024
commit 5ff73f3a3abf17d0ba7207c2085f31dd38165653
8 changes: 7 additions & 1 deletion test/parallel/test-performance-function.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,14 +90,20 @@ const {
}

(async () => {
let _deadCode;

const histogram = createHistogram();
const m = (a, b = 1) => {};
const m = (a, b = 1) => {
for (let i = 0; i < 1e3; i++)
_deadCode = i;
};
const n = performance.timerify(m, { histogram });
assert.strictEqual(histogram.max, 0);
for (let i = 0; i < 10; i++) {
n();
await sleep(10);
}
assert.ok(_deadCode >= 0);
assert.notStrictEqual(histogram.max, 0);
[1, '', {}, [], false].forEach((histogram) => {
assert.throws(() => performance.timerify(m, { histogram }), {
Expand Down