Sitelet https://github.com/nodejs/node/pull/50352/commits/cb1424536a106a38bd19939db559ca01796a72be
Skip to content

test: v8: Add test-linux-perf-logger test suite #50352

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nodejs-github-bot merged 2 commits into from
Oct 25, 2023
Merged

test: v8: Add test-linux-perf-logger test suite #50352

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c300bf3
test: v8: Add test-linux-perf-logger test suite
lukealbao Oct 23, 2023
cb14245
Lint fixes
lukealbao Oct 23, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Lint fixes
  • Loading branch information
@lukealbao
lukealbao committed Oct 23, 2023
commit cb1424536a106a38bd19939db559ca01796a72be
8 changes: 4 additions & 4 deletions test/v8-updates/test-linux-perf-logger.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,7 @@ function runTest(test) {
};

const args = test.nodeFlags.concat(fixtures.path('linux-perf-logger.js'));
const run = spawnSync(process.execPath, args, {cwd: tmpdir.path, encoding: 'utf8'});
const run = spawnSync(process.execPath, args, { cwd: tmpdir.path, encoding: 'utf8' });
if (run.error) {
report.errors.push(run.error.stack);
return report;
Expand Down Expand Up @@ -121,13 +121,13 @@ function runTest(test) {
}

function serializeError(report, index) {
return `[ERROR ${index+1}] ${report.title}
return `[ERROR ${index + 1}] ${report.title}
Errors:
${report.errors.map((err, i) => `${i+1}. ${err}`).join('\n')}
${report.errors.map((err, i) => `${i + 1}. ${err}`).join('\n')}
Perf map content:
${report.perfMap}
</end perf map content>
`
`;
}

function runSuite() {
Expand Down