Sitelet https://github.com/nodejs/node/pull/49825/commits/6f5ed6984ae2d58122903af9ffbe482acc758147
Skip to content

test: replace forEach with for..of in test-process-env-ignore #49825

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nodejs-github-bot merged 3 commits into from
Oct 7, 2023
Merged

test: replace forEach with for..of in test-process-env-ignore #49825

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6f5ed69
test: replace forEach with for..of in test-process-env
niyashiyas Sep 23, 2023
b84fb82
test: replace forEach with for..of in test-process-env
niyashiyas Sep 24, 2023
10f6942
Update test/parallel/test-process-env-ignore-getter-setter.js
lpinca Oct 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
test: replace forEach with for..of in test-process-env
  • Loading branch information
@niyashiyas
niyashiyas committed Sep 30, 2023
commit 6f5ed6984ae2d58122903af9ffbe482acc758147
4 changes: 2 additions & 2 deletions test/parallel/test-process-env-ignore-getter-setter.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ assert.throws(

const attributes = ['configurable', 'writable', 'enumerable'];

attributes.forEach((attribute) => {
for(const attribute of attributes) {
Comment thread
lpinca marked this conversation as resolved.
Outdated
assert.throws(
() => {
Object.defineProperty(process.env, 'goo', {
Expand All @@ -55,7 +55,7 @@ attributes.forEach((attribute) => {
' and enumerable data descriptor'
}
);
});
};
Comment thread
tniessen marked this conversation as resolved.
Outdated

assert.strictEqual(process.env.goo, undefined);
Object.defineProperty(process.env, 'goo', {
Expand Down