Sitelet https://github.com/nodejs/node/pull/49646/commits/aebf089c17c7d1c564749346bfff62e4e6090d3a
Skip to content

test_runner: catch reporter errors #49646

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
MoLow wants to merge 3 commits into from
Closed

test_runner: catch reporter errors #49646

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
38aed2c
test_runner: catch reporter errors
MoLow Sep 21, 2023
a76e97e
fix
MoLow Sep 21, 2023
aebf089
Apply suggestions from code review
MoLow Sep 21, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Apply suggestions from code review 
Co-authored-by: Colin Ihrig <cjihrig@gmail.com>
  • Loading branch information
@MoLow @cjihrig
MoLow and cjihrig authored Sep 21, 2023
commit aebf089c17c7d1c564749346bfff62e4e6090d3a
2 changes: 1 addition & 1 deletion test/fixtures/test-runner/custom_reporters/throwing-async.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
'use strict';

module.exports = async function * customReporter() {
yield "Going to throw an error\n";
yield 'Going to throw an error\n';
setImmediate(() => {
throw new Error('Reporting error');
});
Expand Down
2 changes: 1 addition & 1 deletion test/fixtures/test-runner/custom_reporters/throwing.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
'use strict';

module.exports = async function * customReporter() {
Comment thread
MoLow marked this conversation as resolved.
yield "Going to throw an error\n";
yield 'Going to throw an error\n';
throw new Error('Reporting error');
};