Sitelet https://github.com/nodejs/node/pull/48456/commits/5258be63b30d7ec2cf31b0bd323b1ebb8d751b45
Skip to content

deps: update V8 to 11.5 #48456

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
targos wants to merge 14 commits into from
Closed

deps: update V8 to 11.5 #48456

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
0ddf2b3
deps: update V8 to 11.5.150.10
targos Jun 14, 2023
e8726f8
build: reset embedder string to "-node.0"
targos Jun 14, 2023
5801de2
src: update NODE_MODULE_VERSION to 118
targos Jun 14, 2023
b3fd0cd
deps: always define V8_EXPORT_PRIVATE as no-op
targos Sep 21, 2022
dc3c787
deps: silence irrelevant V8 warning
targos Jun 21, 2022
5258be6
deps: disable V8 concurrent sparkplug compilation
targos Apr 6, 2023
f6c4436
deps: V8: cherry-pick 15e31d629ac0
targos Jun 14, 2023
273686f
tools: update V8 gypfiles for 11.4
targos Mar 31, 2023
fd29941
tools: add new V8 headers to distribution
targos Mar 31, 2023
baa57f1
lib: update usage of always on Atomics API
targos Apr 16, 2023
cc27e4e
test: adapt debugger tests to V8 11.4
pfaffe Mar 17, 2023
ada4cc2
test: update flag to disable SharedArrayBuffer
targos Apr 20, 2023
83435a2
tools: update V8 gypfiles for 11.5
targos Apr 30, 2023
a999c68
test: adapt test-fs-write to V8 internal changes
targos May 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
deps: disable V8 concurrent sparkplug compilation 
It introduces process hangs on some platforms because Node.js doesn't
tear down V8 correctly.
Disable it while we work on a solution.

Refs: #47297
Refs: https://bugs.chromium.org/p/v8/issues/detail?id=13902
PR-URL: #47450
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
  • Loading branch information
@targos
targos committed Jun 21, 2023
commit 5258be63b30d7ec2cf31b0bd323b1ebb8d751b45
2 changes: 1 addition & 1 deletion common.gypi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@

# Reset this number to 0 on major V8 upgrades.
# Increment by one for each non-official patch applied to deps/v8.
'v8_embedder_string': '-node.2',
'v8_embedder_string': '-node.3',

##### V8 defaults for Node.js #####

Expand Down
2 changes: 1 addition & 1 deletion deps/v8/src/flags/flag-definitions.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -787,7 +787,7 @@ DEFINE_BOOL(baseline_batch_compilation, true, "batch compile Sparkplug code")
DEFINE_BOOL_READONLY(concurrent_sparkplug, false,
"compile Sparkplug code in a background thread")
#else
DEFINE_BOOL(concurrent_sparkplug, ENABLE_SPARKPLUG_BY_DEFAULT,
DEFINE_BOOL(concurrent_sparkplug, false,
"compile Sparkplug code in a background thread")
DEFINE_WEAK_IMPLICATION(future, concurrent_sparkplug)
DEFINE_NEG_IMPLICATION(predictable, concurrent_sparkplug)
Expand Down