Sitelet https://github.com/nodejs/node/pull/47998/commits/fddba7341c3dc7763f2da0e14eee026052bb4677
Skip to content

crypto: remove default encoding from cipher #47998

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nodejs-github-bot merged 1 commit into from
May 16, 2023
Merged

crypto: remove default encoding from cipher #47998

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
crypto: remove default encoding from cipher 
Refs: #47182
  • Loading branch information
@tniessen
tniessen committed May 14, 2023
commit fddba7341c3dc7763f2da0e14eee026052bb4677
6 changes: 0 additions & 6 deletions lib/internal/crypto/cipher.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,6 @@ const {
} = require('internal/crypto/keys');

const {
getDefaultEncoding,
getArrayBufferOrView,
getStringOption,
kHandle,
Expand Down Expand Up @@ -172,10 +171,6 @@ Cipher.prototype._flush = function _flush(callback) {
};

Cipher.prototype.update = function update(data, inputEncoding, outputEncoding) {
const encoding = getDefaultEncoding();
inputEncoding = inputEncoding || encoding;
outputEncoding = outputEncoding || encoding;

if (typeof data === 'string') {
validateEncoding(data, inputEncoding);
} else if (!isArrayBufferView(data)) {
Expand All @@ -195,7 +190,6 @@ Cipher.prototype.update = function update(data, inputEncoding, outputEncoding) {


Cipher.prototype.final = function final(outputEncoding) {
outputEncoding = outputEncoding || getDefaultEncoding();
const ret = this[kHandle].final();

if (outputEncoding && outputEncoding !== 'buffer') {
Expand Down