Sitelet https://github.com/nodejs/node/pull/45551/commits/ba1d343a9beb8637977c1658e3c92de5245179dd
Skip to content

src: rename internal module declaration as internal bindings #45551

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
legendecas wants to merge 2 commits into from
Closed

src: rename internal module declaration as internal bindings #45551

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b3c87a0
src: rename internal module declaration as internal bindings
legendecas Nov 20, 2022
ba1d343
fixup! src: rename internal module declaration as internal bindings
legendecas Nov 21, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fixup! src: rename internal module declaration as internal bindings
  • Loading branch information
@legendecas
legendecas committed Nov 21, 2022
commit ba1d343a9beb8637977c1658e3c92de5245179dd
2 changes: 1 addition & 1 deletion src/node.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -749,7 +749,7 @@ static ExitCode InitializeNodeWithArgsInternal(
// Initialize node_start_time to get relative uptime.
per_process::node_start_time = uv_hrtime();

// Register built-in modules
// Register built-in bindings
binding::RegisterBuiltinBindings();

// Make inherited handles noninheritable.
Expand Down
2 changes: 1 addition & 1 deletion src/node_binding.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -652,7 +652,7 @@ void GetLinkedBinding(const FunctionCallbackInfo<Value>& args) {
}

// Call built-in bindings' _register_<module name> function to
// do module registration explicitly.
// do binding registration explicitly.
void RegisterBuiltinBindings() {
#define V(modname) _register_##modname();
NODE_BUILTIN_BINDINGS(V)
Expand Down