Sitelet https://github.com/nodejs/node/pull/43559
Skip to content

test: skip test-icu-env on IBM i - #43559

Closed
V-for-Vasili wants to merge 1 commit into
nodejs:mainfrom
V-for-Vasili:ibmi-skip-test-icu-env
Closed

test: skip test-icu-env on IBM i#43559
V-for-Vasili wants to merge 1 commit into
nodejs:mainfrom
V-for-Vasili:ibmi-skip-test-icu-env

Conversation

@V-for-Vasili

@V-for-Vasili V-for-Vasili commented Jun 24, 2022

Copy link
Copy Markdown
Contributor

Issue: #43509

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to Node.js core tests and test infrastructure. labels Jun 24, 2022
@V-for-Vasili V-for-Vasili mentioned this pull request Jun 24, 2022
Closed
4 tasks done
@V-for-Vasili V-for-Vasili changed the title IBMi: Skip test-icu-env test: skip test-icu-env on IBMi Jun 24, 2022
@V-for-Vasili V-for-Vasili changed the title test: skip test-icu-env on IBMi test: skip test-icu-env on IBM i Jun 24, 2022
@V-for-Vasili

V-for-Vasili commented Jun 24, 2022

Copy link
Copy Markdown
Contributor Author

Fixed commit title, should pass lint-commit-message now

@F3n67u

F3n67u commented Jun 24, 2022

Copy link
Copy Markdown
Contributor

@V-for-Vasili You have to change the commit message to make "lint-commit-message" pass. I saw your commit message is left untouched, it still is IBMi: Skip test-icu-env which is not valid.

@V-for-Vasili
V-for-Vasili force-pushed the ibmi-skip-test-icu-env branch from 72244a7 to 89f07d4 Compare June 24, 2022 15:00
@V-for-Vasili

V-for-Vasili commented Jun 24, 2022

Copy link
Copy Markdown
Contributor Author

Fixed, thanks for the heads up

LiviaMedeiros
LiviaMedeiros approved these changes Jun 24, 2022
View reviewed changes

@LiviaMedeiros LiviaMedeiros left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any clue on why it's so much slow on this platform?

@LiviaMedeiros LiviaMedeiros added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Jun 24, 2022
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Jun 24, 2022
@nodejs-github-bot

nodejs-github-bot commented Jun 24, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/44832/

@richardlau

richardlau commented Jun 24, 2022

Copy link
Copy Markdown
Member

Sorry, I was waiting to the IBM i test CI I started earlier to complete -- I extended the test timeout on IBM i in the CI from the default 2 minutes to 5 minutes and test-icu-env passed in the test build: https://ci.nodejs.org/job/node-test-commit-ibmi/803/nodes=ibmi73-ppc64/testReport/(root)/test/parallel_test_icu_env/

@V-for-Vasili

V-for-Vasili commented Jun 24, 2022

Copy link
Copy Markdown
Contributor Author

Closing since this is not needed with longer timeout.

@LiviaMedeiros Certain tests on IBMi can take longer to run than on linux, but usually not to that extent; This ICU test time difference seems to be an outlier and is worth a separate investigation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@LiviaMedeiros LiviaMedeiros LiviaMedeiros approved these changes

Assignees

No one assigned

Labels

needs-ci PRs that need a full CI run. test Issues and PRs related to Node.js core tests and test infrastructure.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@V-for-Vasili @F3n67u @nodejs-github-bot @richardlau @LiviaMedeiros