Sitelet https://github.com/nodejs/node/pull/1467/commits/ff88a4ff45b78ee5d74d783332f736acdee86427
Skip to content

http: revert 06cfff93, fixes overridden options #1467

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
brendanashworth wants to merge 4 commits into from
Closed

http: revert 06cfff93, fixes overridden options #1467

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
cd7023c
Revert "http: don't bother making a copy of the options"
brendanashworth Apr 18, 2015
8bccb49
test: add test for 06cfff9 regression
brendanashworth Apr 18, 2015
ff88a4f
!fixup fix test's localhost for FreeBSD runs
brendanashworth Apr 18, 2015
6e5cc0a
!fixup more verbose test name
brendanashworth Apr 18, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
!fixup fix test's localhost for FreeBSD runs
  • Loading branch information
@brendanashworth
brendanashworth committed Apr 18, 2015
commit ff88a4ff45b78ee5d74d783332f736acdee86427
4 changes: 2 additions & 2 deletions test/parallel/test-http-dont-override-options.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ agent.defaultPort = common.PORT;
// be mutable / modified
var options = {
host: undefined,
hostname: 'localhost',
hostname: common.localhostIPv4,
port: undefined,
defaultPort: undefined,
path: undefined,
Expand All @@ -37,7 +37,7 @@ process.on('exit', function() {
assert.equal(requests, 1);

assert.strictEqual(options.host, undefined);
assert.strictEqual(options.hostname, 'localhost');
assert.strictEqual(options.hostname, common.localhostIPv4);
assert.strictEqual(options.port, undefined);
assert.strictEqual(options.defaultPort, undefined);
assert.strictEqual(options.path, undefined);
Expand Down