Test_runner: --experimental-test-coverage generates partial file names

Version

v21.5.0

Platform

Microsoft Windows NT 10.0.22621.0 x64

Subsystem

No response

What steps will reproduce the bug?

This issue only happens in windows; mac works fine.

How often does it reproduce? Is there a required condition?

No response

What is the expected behavior? Why is that the expected behavior?

No response

What do you see instead?

I see partial file names

Here is the coverage report generated in windows:

# start of coverage report
# ------------------------------------------------------------------------------------------------------------------------------------------------------
# file     | line % | branch % | funcs % | uncovered lines
# ------------------------------------------------------------------------------------------------------------------------------------------------------
# …test.js | 100.00 |   100.00 |  100.00 | 
# …test.js | 100.00 |    88.89 |  100.00 | 
# …ties.js |  28.96 |    53.33 |   14.29 | 22-27 37-50 56-61 64-75 77-79 81-87 115 119-132 146-148 152-154 156-158 160-164 166-174 177-180 182-184 186…
# ------------------------------------------------------------------------------------------------------------------------------------------------------
# all fil… |  39.07 |    72.41 |   30.00 |
# ------------------------------------------------------------------------------------------------------------------------------------------------------
# end of coverage report

Here is my complete command:

node --test --test-concurrency=1 --experimental-test-coverage --test-reporter=tap --test-reporter-destination=code/test/testlog.tap code/test/*.test.js

Additional information

The issue happens if my test.js files contains const {somefunc} = require('../mymodule') i.e importing module by relative path

if anyone is intrested in tackling this issue, the width of the columns is calculated here:

node/lib/internal/test_runner/utils.js

Lines 357 to 362 in 477d6d7

    
           const minFilePad = MathMin(8, filePadLength); 
        
           filePadLength -= MathFloor(columnsExtras * 0.2); 
        
           filePadLength = MathMax(filePadLength, minFilePad); 
        
           // Get rest of available space, subtracting margins 
        
           uncoveredLinesPadLength = MathMax(availableWidth - columnsWidth - (filePadLength + 2) - 2, 1);

@fawazahmed0

Hi @fawazahmed0 @MoLow - can you please assign this to me, I am interested in this issue. Thank you!

@ArchitGajjar

@ArchitGajjar seems like #51351 is already open, anyway, we don't assign issues to people.

@MoLow

Is this issue solved #51299 @MoLow @fawazahmed0

@Medhansh404

Hello, I have run several tests on this issue and the problem occurs on my dad's windows 10 computer and my Ubuntu 22.04 PC.
However, it works correctly on my winodws 11 laptop.

I am just starting to get into contributing to open-source, and I thought this would be a good first challenge for me.

If this issue is not solved #51351 @Medhansh404 @MoLow @fawazahmed0 then I would like to take a crack at it.

Thanks, John

test_runner: avoid coverage report partial file names

Navigation Menu

Repository navigation

Test_runner: `--experimental-test-coverage` generates partial file names #51299

Version

Platform

Subsystem

What steps will reproduce the bug?

How often does it reproduce? Is there a required condition?

What is the expected behavior? Why is that the expected behavior?

What do you see instead?

Additional information

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

	const minFilePad = MathMin(8, filePadLength);
	filePadLength -= MathFloor(columnsExtras * 0.2);
	filePadLength = MathMax(filePadLength, minFilePad);

	// Get rest of available space, subtracting margins
	uncoveredLinesPadLength = MathMax(availableWidth - columnsWidth - (filePadLength + 2) - 2, 1);

Test_runner: --experimental-test-coverage generates partial file names #51299

Description

Version

Platform

Subsystem

What steps will reproduce the bug?

How often does it reproduce? Is there a required condition?

What is the expected behavior? Why is that the expected behavior?

What do you see instead?

Additional information

Activity

MoLow commented on Jan 2, 2024

ArchitGajjar commented on Jan 3, 2024

MoLow commented on Jan 4, 2024

saloni0419 commented on Jan 25, 2024

buzzinJohnnyBoi commented on Jan 28, 2024

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions

Test_runner: `--experimental-test-coverage` generates partial file names #51299