Make it possible to set Response/Request highWaterMark on http.Server #46606

Activity

1. ronag

   added

   help wantedIssues that need assistance from volunteers or PRs that need help to proceed.Issues that need assistance from volunteers or PRs that need help to proceed.

   httpIssues and PRs related to the http subsystem.Issues and PRs related to the http subsystem.

   feature requestIssues requesting new Node.js features.Issues requesting new Node.js features.

   on Feb 10, 2023
2. ronag commented on Feb 10, 2023

   

   ronag

   on Feb 10, 2023

   MemberAuthor

   More actions

   @nodejs/performance
3. ronag

   changed the title [-]Make it possible to set ServerResponse/Request high water mark on Server[/-] [+]Make it possible to set `ServerResponse/Request` `highWaterMark` on `http.Server`[/+] on Feb 10, 2023
4. ronag

   changed the title [-]Make it possible to set `ServerResponse/Request` `highWaterMark` on `http.Server`[/-] [+]Make it possible to set `Response/Request` `highWaterMark` on `http.Server`[/+] on Feb 10, 2023
5. mcollina commented on Feb 10, 2023

   

   mcollina

   on Feb 10, 2023

   SponsorMember

   More actions

   I think we can safely increase it. Maybe bring it to 32KB both ways?
6. ronag commented on Feb 10, 2023

   

   ronag

   on Feb 10, 2023

   MemberAuthor

   More actions

   I think we can safely increase it. Maybe bring it to 32KB both ways?

   #46608 does takes us some of the way but I think it's varies from case to case how high one can go, e.g a large amazon instance vs a raspberry pi.

   👍React with 👍2Reacted by Luigi Pinca and Raz Luvaton

   👀React with 👀1Reacted by Toni Villena
7. benjamingr commented on Feb 10, 2023

   

   benjamingr

   on Feb 10, 2023

   Member

   More actions

   Was about to repeat what Matteo said - can we just increase it?

   If we can't do it safely across all envs - can we just increase it based on some parameter of the system?
8. ronag commented on Feb 10, 2023

   

   ronag

   on Feb 10, 2023

   MemberAuthor

   More actions

   Some push back in #46608

   👍React with 👍2Reacted by Benjamin Gruenbaum and MK (fengmk2)
9. targos

   added this to Node.js feature requestson Mar 10, 2023
10. github-project-automation

    moved this to Pending Triage in Node.js feature requestson Mar 10, 2023
11. HinataKah0 commented on Mar 22, 2023

    

    HinataKah0

    on Mar 22, 2023

    Last edited by HinataKah0

    Contributor

    More actions

    Hi,
    I am interested to work on the changes.

    What I have tried,

    Option 1:

    1. Store the new opt in storeHTTPOptions
    2. Set it when calling IncomingMessage
    3. Set it when calling ServerResponse, similar to setting kUniqueHeaders

    Draft Commit

    Option 2:

    Set both (readable|writable)HighWaterMark when creating a new Socket.

    Draft Commit

    I'll open a PR. If this is no longer needed, please close it. 😄
    Thanks!
12. HinataKah0

    added a commit that references this issue on Apr 21, 2023

    http: add highWaterMark opt in http.createServer

    ...

    25a6e25
13. nodejs-github-bot

    closed this as completedin #47405on Apr 24, 2023
14. nodejs-github-bot

    added a commit that references this issue on Apr 24, 2023

    http: add highWaterMark opt in http.createServer

    ...

    2fbe124
15. targos

    added a commit that references this issue on May 2, 2023

    http: add highWaterMark opt in http.createServer

    ...

    4fa7739
16. danielleadams

    added a commit that references this issue on Jul 6, 2023

    http: add highWaterMark opt in http.createServer

    ...

    46ee19c
17. MoLow

    added a commit that references this issue on Jul 6, 2023

    http: add highWaterMark opt in http.createServer

    ...

    7cef6aa
18. avivkeller

    moved this from Awaiting Triage to Done in Node.js feature requestson Aug 6, 2024
19. avivkeller

    removed this from Node.js feature requestson Sep 13, 2024