Repository navigation
Optional parameter strategy for stream.Readable.toWeb()? #43487
Description
Activity
@nodejs/streams
@rauschma hey Axel, sure this is a pretty easy fix, the code is in /lib/internal/webstreams/adapters.js line 389, the code currently just does:
const strategy = objectMode ? new CountQueuingStrategy({ highWaterMark }) : { highWaterMark };
Would you be interested in contributing a fix? (Happy to guide you through)
I took it upon myself to make a change to include a
strategyparameter in the.toWeb()method inside theReadable.jsstream object.This would be my first PR against the Node code base, please don't be too hard on me lol.
The tests are pending but I would love to hear how I can approach them.
Reacted by Benjamin GruenbaumThere has been no activity on this feature request for 5 months and it is unlikely to be implemented. It will be closed 6 months after the last non-automated comment.
For more information on how the project manages feature requests, please consult the feature request management document.
This already landed 🎉
Reacted by Axel Rauschmayer
What is the problem this feature will solve?
Currently, it is not possibly to customize the queueing strategy of the ReadableStream returned by
stream.Readable.toWeb().What is the feature you are proposing to solve the problem?
Change the signature from:
What alternatives have you considered?
I’m not aware of any alternatives: As far as I know, there is no way to change the queuing strategy of a ReadableStream after its constructor was invoked.