Repository navigation
--findRelatedTests for node:test #42992
Description
Activity
/cc @nodejs/test_runner
How would node determine this?
jest does it because it has a bunch of complex code to build a dependency map - but node would have to actively parse all your code to find the static requires/imports, and would have to evaluate your code to find the dynamic ones. This seems like something way out of scope for node core to do.
I'd expect node to determine the dependency map. If you think this feature is outside of node core, that's fair. Would still love to see this in node core if not now, maybe later on.
I think that capability would need to land first, separately, before the test runner could use it.
Reacted by Ben Stickley@ljharb @bestickley basically this PR kind of does that,
when running insidedescribeit first maps all subtests, then runs only top-level tests, so it probably wont require a lot of modification to extract a list of all tests before they run (only when usingdescribeandit)
https://github.com/nodejs/node/blob/38327e7c720a99cc841f95e0e748c1797e8c6a81/lib/internal/test_runner/harness.js#L143-L145Reacted by Ben Stickley"only when using
describeandit" wouldn't be an acceptable caveat, imo, since all supported testing styles need to be usable with a feature.Reacted by Julian Gruber and Colin Ihrig"only when using
describeandit" wouldn't be an acceptable caveat, imo, since all supported testing styles need to be usable with a feature.I agree. I was just pointing out my PR lays the ground for that
jest does it because it has a bunch of complex code to build a dependency map - but node would have to actively parse all your code to find the static requires/imports, and would have to evaluate your code to find the dynamic ones. This seems like something way out of scope for node core to do.
Totally agree, this would be very complex. I, for one, am interested in a simpler, more reliable test runner after having struggled for long enough with jest & the like. It's my hope that
node:testwill avoid complexity bombs like this and provide a simple to understand substrate on which to build.I think this feature would be more appropriate as a userland implementation. It's fairly complex and I think would also need to be too opinionated about what your project looks like (CJS? ESM? Typescript?), path resolution, and how changes should be identified. You can introduce a ton of config like jest does but that's best left to users IMO.
A rough sketch of how I'd do it:
- Write a custom test entry using
runthat determines a list of test files - Use something like es module lexer to recursively parse imports from those test files to their dependencies, dependencies of dependencies etc to build up a module dependency graph. Dynamic imports would be a significant challenge here.
- Identify changed files by parsing git state like the index file (it's fairly straight-forward to do) or using a node git client to do so.
- Traverse the dependency graph to find test file leaves related to changed module nodes. Only note here is that module graphs aren't necessarily acyclic so some cation would be needed in the traversal implementation.
- Pass the list of test file leafs related to changed files to
runinstead of the full list.
Reacted by Connor Peet- Write a custom test entry using
There has been no activity on this feature request for 5 months and it is unlikely to be implemented. It will be closed 6 months after the last non-automated comment.
For more information on how the project manages feature requests, please consult the feature request management document.
There has been no activity on this feature request and it is being closed. If you feel closing this issue is not the right thing to do, please leave a comment.
For more information on how the project manages feature requests, please consult the feature request management document.
What is the problem this feature will solve?
I use lintstaged to run only the unit tests related to changed source files on each commit. I currently use jest with their CLI flag:
--findRelatedTests(https://jestjs.io/docs/cli#--findrelatedtests-spaceseparatedlistofsourcefiles). Could something similar be added to node:test?What is the feature you are proposing to solve the problem?
--findRelatedTests CLI flag
What alternatives have you considered?
Sticking with Jest or creating my own helper function.