Sitelet https://github.com/nodejs/node/issues/123#top
Skip to content

Async listener removal also drops tracing #123

Closed
Closed
Async listener removal also drops tracing#123

Description

@piscisaureus
piscisaureus
opened on Dec 9, 2014

I was trying to merge @trevnorris' asynclister removal (#124) but I noticed that require('tracing').v8 had also been removed. Is this desired?

@trevnorris @bnoordhuis

Activity

  1. bnoordhuis commented on Dec 9, 2014

    @bnoordhuis
    bnoordhuis
    on Dec 9, 2014
    Member

    IIRC, @trevnorris and I agreed to move the v8 stuff to a separate v8 module. I'll file a PR when #124 lands.

  2. trevnorris commented on Dec 9, 2014

    @trevnorris
    trevnorris
    on Dec 9, 2014
    Contributor

    @piscisaureus The raw parts are still accessible through process.binding('v8');. Reason I left it out is because, IIRC, grabing GC statistics in the middle of GC is still dangerous.

  3. piscisaureus commented on Dec 9, 2014

    @piscisaureus
    piscisaureus
    on Dec 9, 2014
    ContributorAuthor

    Continues in #131

  4. piscisaureus
    closed this as completedon Dec 9, 2014
  5. pitimon
    added a commit that references this issue on Jul 25, 2026

    fix(validate): trailing comments read as requests; waivers covered wh…

    e5dc56c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions