Repository navigation
fix: preserve once listeners in inline tasks - #620
Open
bensynapse wants to merge 1 commit into
Open
bensynapse wants to merge 1 commit into
bensynapse wants to merge 1 commit into
Conversation
Calling EventEmitter.listeners() skips the wrapper that removes once listeners. Invoke raw listeners with their emitter receiver so callbacks run once and retain their usual binding. Keep listener error capture.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I run Live Tennis API.
task.once('execution:finished', callback)currently fires for every execution and leaves its listener registered. The inline dispatcher callslisteners(), which unwraps once listeners.Dispatch
rawListeners()with the EventEmitter receiver. This restores once cleanup and normal listener binding while keeping synchronous and async listener errors isolated.Five regression tests fail before the fix.
npm run checkpasses all 758 tests on Node 22. The suite also passes on Node 20 and 24, and Node 22 withTZ=America/Sao_Paulo.npm run typecheckandnpm run buildpass. Built ESM and CommonJS checks pass, including real background executions.For the background checks I called
stop()beforedestroy(). Direct CommonJSdestroy()can time out on both main and this branch.