Sitelet https://github.com/nextcloud/.github/pull/803
Skip to content

ci: migrate to nextcloud-libraries/parse-package-engines-action - #803

Merged
susnux merged 1 commit into
masterfrom
feature/parse-package-engines-action
Oct 6, 2026
Merged

susnux merged 1 commit into
masterfrom
feature/parse-package-engines-action

Conversation

@skjnldsv

@skjnldsv skjnldsv commented Oct 2, 2026 •

Copy link
Copy Markdown
Member

Moves the 12 remaining templates to parse-package-engines-action v0.1.0, already used by playwright.yml and the nextcloud-libraries templates.

No more fallbacks, apps are expected to set engines. The steps that skip without a package.json now check the step outcome, and appstore-build-publish passes the package.json path instead of the folder.

🤖 AI (if applicable)

  • The content of this PR was partly or fully generated using AI

Comment thread workflow-templates/appstore-build-publish.yml Outdated
@skjnldsv
skjnldsv force-pushed the feature/parse-package-engines-action branch from 6b64d68 to 8b62ab4 Compare October 6, 2026 08:12
@skjnldsv
skjnldsv requested a review from susnux October 6, 2026 08:12
It also reads devEngines and is already used by the playwright template
and the nextcloud-libraries templates. It has no fallback inputs, and apps
are expected to set engines in their package.json, so the fallbacks go.
The steps that skip when there is no package.json now check the step
outcome instead of the output.

Assisted-by: ClaudeCode:claude-opus-5-5
Signed-off-by: John Molakvoæ <14975046+skjnldsv@users.noreply.github.com>
@skjnldsv
skjnldsv force-pushed the feature/parse-package-engines-action branch from 8b62ab4 to 121bf70 Compare October 6, 2026 08:12
@susnux
susnux merged commit 80626eb into master Oct 6, 2026
6 checks passed
@susnux
susnux deleted the feature/parse-package-engines-action branch October 6, 2026 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews AI assisted This PR contains AI-assisted commits enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants