Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
LinuxandWindowsworkflows each get akeepalivejob (liskin/gh-workflow-keepalive@v1) that runs only on their weekly schedule and re-enables its own workflow. The regeneration steps now fail when regenerating changes the committed sources.keepalivejob inbuild_linux.ymlandbuild_windows.ymlwithactions: write. The action re-enables only the workflow it runs in, so each scheduled workflow needs one of its own.keep_alive.ymlremoved: it only kept itself alive, and no other scheduled workflow is left that needs it(sources regeneration)build steps end withgit add --intent-to-add --all -- <gen dir>+git diff --exit-code -- <gen dir>, forsrcandpmr/src. New files count as drift too.CMakeLists.txtandpmr/CMakeLists.txtpass-ignoreTimestampsto zserio. Without it, zserio skips output files that are newer thantutorial.zs, so the check passed without regenerating anything.Verified:
git diff": ran the regeneration locally for.andpmr(latest zserio release); cmake exit 0 every time. On the committed sources the check exits 0. With an extra line committed insrc/tutorial/Employee.handpmr/src/tutorial/Employee.h, regeneration removes it and the check exits 1 for each. Before-ignoreTimestamps, that same committed edit gave exit 0.write_joe/read/write_boss/read→ build exit 0, run exit 0build_linuxpass (1m0s),build_windowspass (2m31s) at55f6890, including the new diff check on both; bothkeepalivejobs skipped as intended onpull_requestactionlinton both workflows → exit 1, 10 findings. All are in lines that already existed (checkout@v3,setup-java@v3,setup-python@v4, SC2035 onrm -rd *), none in the lines added here.5 files changed, 30 insertions(+), 16 deletions(-)Not verified: the
keepalivejob itself. It runs only onschedule, so the first real run is the next Sunday cron.Closes #2