deps: bump deps - #239
deps: bump deps#239
Conversation
|
Documentation for this PR has been generated and is available at: https://n0-computer.github.io/net-tools/pr/239/docs/net_tools/ Last updated: 2026-10-05T14:49:18Z |
|
Please tick the boxes :) |
Now done |
| "proc-macro2", | ||
| "quote", | ||
| "syn 3.0.3", | ||
| "syn 3.0.6", |
There was a problem hiding this comment.
oh no. at some point we only had a single version of syn in our deps... when did we loose this (clearly not this PR)? My bad for not using cargo-deny for this when it was first spotted.
There was a problem hiding this comment.
Yeah. portmapper has 3 syn versions in-tree (1, 2, and 3). I think there's not much to do about it apart from hoping that it collapses to version 3 sometime soonish, or helping out. I think most of our own derive macro crates are using syn@2. But serde derive is using syn@3, so we should move to that. syn@1 is used by ntest, which we might not need (it's only used for a single test).
TLDR I don't think we can do much about it here right now.
|
|
||
| [dependencies] | ||
| base64 = "0.22.1" | ||
| base64 = "0.23.1" |
There was a problem hiding this comment.
this introduces a new duplicate dependency. is it worth it?
There was a problem hiding this comment.
In iroh we have both versions in any case because current reqwest has a dependency on base64@0.23.
The dependency on base64@0.22 will go out of our tree over time hopefully as other upstream deps update.
But yes, it adds a duplicate dependency to portmapper. It will go away once igd-next is released, because then we can remove the attohttpc dependency (that currently pulls in base64@0.22) entirely (see dariusc93/rust-igd#23)
flub
left a comment
There was a problem hiding this comment.
LGTM, we need to get better at justifying duplicate dependencies I think.
|
The |
Description
API Changes
Notes & open questions
Change checklist
proposed change and wrote an as clear and concise description as
they could.
intented effect.
cargo makepasses locally.