Conversation
Notify, describe, poll and listener add and remove reach a channel by name, or a channel linked to a Workflow or a standalone Activity. Refusals come back in plain language with what to do next.
A Workflow that listens on channels says so next to its callbacks, so its subscriptions show up without a second command.
The server calls no callback address until one is allowed, and a local receiver on a dev server rarely serves TLS. A dynamic config value still replaces the list.
Fake-service cases pin the requests and the plain refusals, and the shared dev server cases run each command against a real channel, linked or not.
2 of 3 tasks
Owner
Author
|
Paused per the 2026-10-05 design review (the decision record is on the proposal page, section 14). Resumes in phase 2 with the CHASM notification work. The branch stays as a pin. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds
temporal channel, lists a Workflow's channels inworkflow describeand lets the dev server call local callback listeners.What changed?
temporal channel notify,describe,poll,listener addandlistener remove.-cnames the channel. With--workflow-idor--activity-idand an optional--run-idit's the channel linked to that execution, sent as the request'sexecution. Without an owner it's the independent channel of that name.notifytakes--position,--counterand--metadata KEY=VALUEwith JSON values and prints how many listeners it reached.describeshows the kind, the owner line, what's retained and both listener tables.pollwaits up to--waitabove--after-counter, and--followkeeps going from the last counter seen.listener addtakes a callback URL with--headervalues and prints the IDlistener removetakes.refusalErrorinrefusal.go, andpayloadTextjoinspayload.go, so the stream commands can share both later.temporal workflow describeprints a Notification Channels table when the Workflow listens on any.temporal server start-devallows callbacks to127.0.0.1andlocalhoston any port over plain HTTP.--dynamic-config-value 'callback.allowedAddresses=...'still replaces the list.Part of AI-198 (epic AI-37).
Why?
It gives the notification channel a terminal front. You can play a writer with
notify, a client listener withpolland a callback listener withlistener add, anddescribeshows what the server holds. The channel calls are publicWorkflowServicecalls, so the SDK client and its codec interceptor cover them with no new plumbing. The server calls no callback address until one is allowed, and upstream allows none by default. A local receiver rarely serves TLS, so the dev server allows local addresses out of the box.How did you test it?
Link to a test plan if any -
The
TestChannelunit tests run each command against an in-process fake of the workflow service: flag checks that send nothing, the request each command sends with either owner, text and JSON output,--follow, the plain refusals and theworkflow describetable. TheTestChannelsuite cases run on the shared dev server. They cover retention without listeners, folding a stale counter, a poll that waits, a callback round trip, an unknown channel, and linked channels on a running Workflow and on a standalone Activity. I ran the rest ofSharedServerSuiteand the other packages too, since the server module moved.go mod tidyand the generators leave no diff. By hand ontemporal server start-dev --headless, I ran every command on an independent channel and again with--workflow-idon a running Workflow, includingworkflow describeand the refusal after it was terminated.