fix(ui): stop wheel scroll and stale hover from drifting comment targets off the highlighted line - #1143
Open
HackAttack wants to merge 1 commit into
Open
fix(ui): stop wheel scroll and stale hover from drifting comment targets off the highlighted line#1143HackAttack wants to merge 1 commit into
HackAttack wants to merge 1 commit into
Conversation
…ets off the highlighted line A 'c' comment could open its draft a few lines (or one collapsed gap) away from the highlighted line. Two paths let the line cursor drift away from the current line: - Wheeling past the highlighted line clamped the cursor to a viewport edge, and wheeling back never restored it; the strand survived the whole roundtrip and deepened with distance. - A hover add-note affordance stayed armed after the cursor stepped away, so the next implicit comment targeted the hovered row instead of the highlight. The clamp now remembers the stop it displaced, unwinding one hop per scroll step back, and a deliberate cursor move ends the unwind; cursor movement retires a stale hover. Keyboard-only commenting was always exact and is unchanged. A vertical drag across exactly two rows was also swallowed: the click slop that ignores one cell of pointer jitter applied to the row axis, so a two-row gesture read as a jittered click and painted no selection or action bar. The slop is now horizontal only. Co-authored-by: GLM-5.3-Flash
Contributor
|
PR author is not in the allowed authors list. |
|
@HackAttack is attempting to deploy a commit to the Modem Team on Vercel. A member of the Team first needs to authorize it. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A 'c' comment could open its draft a few lines (or one collapsed gap) away from the highlighted line. Two paths let the line cursor drift away from the current line:
The clamp now remembers the stop it displaced, unwinding one hop per scroll step back, and a deliberate cursor move ends the unwind; cursor movement retires a stale hover. Keyboard-only commenting was always exact and is unchanged.
A vertical drag across exactly two rows was also swallowed: the click slop that ignores one cell of pointer jitter applied to the row axis, so a two-row gesture read as a jittered click and painted no selection or action bar. The slop is now horizontal only.