Conversation
This adds tests for handling paths containing double quotes, and is the equivalent of the tests added in containerd/containerd#4325 Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
thaJeztah
force-pushed
the
mountinfo_quotes
branch
from
September 22, 2020 09:32
2e1bb15 to
327c37a
Compare
thaJeztah
marked this pull request as ready for review
September 22, 2020 09:35
Member
Author
|
@kolyshkin @AkihiroSuda PTAL |
Collaborator
|
Not sure we need it. Technically, all this is already covered by |
Collaborator
|
As I suggested in containerd/containerd#4325 (comment) I'd rather have unit tests in such case -- and the "unit" here is the unescape function. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds tests for handling paths containing double quotes, and is the equivalent of the tests added in containerd/containerd#4325