Sitelet https://github.com/mobxjs/mobx-angular/pull/171
Skip to content

Angular 15 support - #171

Merged
SimonMcKinsey merged 1 commit into
mobxjs:masterfrom
modus-jose:master
Jan 24, 2023
Merged

SimonMcKinsey merged 1 commit into
mobxjs:masterfrom
modus-jose:master

Conversation

@modus-jose

@modus-jose modus-jose commented Dec 6, 2022 •

Copy link
Copy Markdown

@EVASIVE can you help me test, projects that upgrade are blocked by enforcing peer dependencies

@SimonMcKinsey

Copy link
Copy Markdown

@modus-jose Thank you for your PR.
I'll have a look at it.

@Whylandos

Copy link
Copy Markdown

please add angular 15 support
npm ERR! peer @angular/common@">=11.1.1 <15.0.0" from mobx-angular@4.6.0
npm ERR! node_modules/mobx-angular
npm ERR! mobx-angular@"4.6.0" from the root project

@kaemmi84

Copy link
Copy Markdown

I also need angular 15 support.

@Mas2112

Mas2112 commented Jan 18, 2023

Copy link
Copy Markdown

I have tested mobx-angular on Angular 15 with my fairly large project. So far our E2E tests and our manual tests have not found any issues. Can we get this PR merged?

@SimonMcKinsey

Copy link
Copy Markdown

Merged.
I will publish it later today/tomorrow.

@michermd

Copy link
Copy Markdown

Hello @SimonTouitou any update?

@michermd

Copy link
Copy Markdown

Hello @SimonTouitou can you provide a timeframe for the publication?

@Chuckv01 Chuckv01 mentioned this pull request Jan 25, 2023
@Chuckv01

Copy link
Copy Markdown
Contributor

This version has been published to npm.

@Whylandos

Copy link
Copy Markdown

Thank you.

It does not seem to work, sadly.

Angular 15 & different node / npm versions I tried.

Cannot find module 'mobx-angular' or its corresponding type declarations.

@modus-jose

modus-jose commented Jan 26, 2023 •

Copy link
Copy Markdown
Author

@Whylandos I get the same error from the version published @Chuckv01

@Chuckv01

Copy link
Copy Markdown
Contributor

🤦 Sorry folks - didn't run npm publish from the dist directory. 4.7.1 should fix that issue.

@Whylandos

Copy link
Copy Markdown

it works

thanks a lot

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants