Sitelet https://github.com/microsoft/vscode-python-devicesimulator/pull/336
Skip to content
This repository was archived by the owner on Dec 23, 2021. It is now read-only.

Remove preview mode for CLUE - #336

Merged
Vandy Liu (vandyliu) merged 4 commits into
devfrom
users/t-vali/remove-preview-mode
Apr 17, 2020
Merged

Vandy Liu (vandyliu) merged 4 commits into
devfrom
users/t-vali/remove-preview-mode

Conversation

@vandyliu

@vandyliu Vandy Liu (vandyliu) commented Apr 17, 2020 •

Copy link
Copy Markdown
Contributor

AB#34624

Description:

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

Limitations:

Please describe limitations of this PR

Testing:

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Checklist:

  • My code follows the style guidelines of this project
  • My code has been formatted with npm run format and passes the checks in npm run check
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Just to make sure, the preview tutorial was removed in the other pr right?

@vandyliu
Vandy Liu (vandyliu) merged commit e39f77f into dev Apr 17, 2020
@vandyliu
Vandy Liu (vandyliu) deleted the users/t-vali/remove-preview-mode branch April 17, 2020 20:55
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants