Sitelet https://github.com/microsoft/vscode-python-devicesimulator/pull/330
Skip to content
This repository was archived by the owner on Dec 23, 2021. It is now read-only.

Fixed debugger bug for white leds and red led - #330

Merged
Vandy Liu (vandyliu) merged 2 commits into
devfrom
users/t-vali/debugger-led-bug-fix
Apr 15, 2020
Merged

Fixed debugger bug for white leds and red led#330
Vandy Liu (vandyliu) merged 2 commits into
devfrom
users/t-vali/debugger-led-bug-fix

Conversation

@vandyliu

@vandyliu Vandy Liu (vandyliu) commented Apr 15, 2020 •
edited by azure-boards Bot
Loading

Copy link
Copy Markdown
Contributor

AB#34600

Description:

  • Included debug mode when sending state changes for white LEDs and red LEDs
  • For future, we should change send_to_simulator to account for both cases (Will do next week)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

Limitations:

Please describe limitations of this PR

Testing:

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Checklist:

  • My code follows the style guidelines of this project
  • My code has been formatted with npm run format and passes the checks in npm run check
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

xnkevinnguyen
Kevin Nguyen (xnkevinnguyen) approved these changes Apr 15, 2020
View reviewed changes
Comment thread src/clue/adafruit_clue.py
sendable_json = {led: value}
utils.send_to_simulator(sendable_json, CONSTANTS.CLUE)
if common.utils.debug_mode:
common.debugger_communication_client.debug_send_to_simulator(

@xnkevinnguyen Kevin Nguyen (xnkevinnguyen) Apr 15, 2020

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

isadorasophia
Isa (isadorasophia) approved these changes Apr 15, 2020
View reviewed changes

@isadorasophia Isa (isadorasophia) left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@vandyliu
Vandy Liu (vandyliu) merged commit 5eca6b4 into dev Apr 15, 2020
@vandyliu
Vandy Liu (vandyliu) deleted the users/t-vali/debugger-led-bug-fix branch April 15, 2020 20:25
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@abmahdy Ahmed Mahdy (abmahdy) Awaiting requested review from abmahdy abmahdy is a code owner
@adclements Andrew Clements (adclements) Awaiting requested review from adclements adclements is a code owner
@iennae Jennifer Davis (iennae) Awaiting requested review from iennae
@markAtMicrosoft Mark Schramm (markAtMicrosoft) Awaiting requested review from markAtMicrosoft
@nasadigital David Serafimov (nasadigital) Awaiting requested review from nasadigital
@sagarmanchanda Sagar Manchanda (sagarmanchanda) Awaiting requested review from sagarmanchanda sagarmanchanda is a code owner
@smmatte smmatte Awaiting requested review from smmatte smmatte is a code owner
@andreamah Andrea Mah (andreamah) Awaiting requested review from andreamah
2 more reviewers
@isadorasophia Isa (isadorasophia) isadorasophia approved these changes
@xnkevinnguyen Kevin Nguyen (xnkevinnguyen) xnkevinnguyen approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@vandyliu @isadorasophia @xnkevinnguyen