This repository was archived by the owner on Dec 23, 2021. It is now read-only.
CLUE unimplemented properties print correctly - #324
Merged
Vandy Liu (vandyliu) merged 1 commit intoApr 13, 2020
Merged
Conversation
Vandy Liu (vandyliu)
requested review from
Andrea Mah (andreamah) and
Kevin Nguyen (xnkevinnguyen)
April 13, 2020 21:25
David Serafimov (nasadigital)
approved these changes
Apr 13, 2020
David Serafimov (nasadigital)
left a comment
There was a problem hiding this comment.
Nice catch, I guess it's trickier when it's a property.
LGTM!
Kevin Nguyen (xnkevinnguyen)
approved these changes
Apr 13, 2020
Kevin Nguyen (xnkevinnguyen)
left a comment
Contributor
There was a problem hiding this comment.
LGTM
Vandy Liu (vandyliu)
deleted the
users/t-vali/clue-unimplemented-properties
branch
April 13, 2020 22:16
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AB#34577
Description:
Type of change
Please delete options that are not relevant.
Limitations:
Please describe limitations of this PR
Testing:
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Checklist:
npm run formatand passes the checks innpm run check