This repository was archived by the owner on Dec 23, 2021. It is now read-only.
Fix issue where incorrect device was loaded - #323
Merged
Merged
Conversation
David Serafimov (nasadigital)
approved these changes
Apr 13, 2020
David Serafimov (nasadigital)
left a comment
There was a problem hiding this comment.
Good catch, fixes issue for me. LGTM!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
The incorrect device is loaded whenever multiple devices were loaded in a row, then a rerender of the webview loads the incorrect device.
Steps to reproduce:
1- Load device 1
2-Load device 2
3- Hide the webview simulator by switching window
4- Focus again on webview simulator
Current behaviour: Device 1 will load
Expected behaviour: Device 2 should load
The fix is to load the new html with correct device instead of saving it as a React state. Since rerender can be triggered, the react state can be lost, but html variables will persist.