Sitelet https://github.com/microsoft/vscode-python-devicesimulator/pull/301
Skip to content
This repository was archived by the owner on Dec 23, 2021. It is now read-only.

Telemetry for CLUE on Python Side - #301

Merged
Vandy Liu (vandyliu) merged 3 commits into
devfrom
users/t-vali/clue-python-telemetry
Apr 8, 2020
Merged

Vandy Liu (vandyliu) merged 3 commits into
devfrom
users/t-vali/clue-python-telemetry

Conversation

@vandyliu

Copy link
Copy Markdown
Contributor

Description:

  • Added telemetry for
    • all adafruit_clue functions
    • adafruit slideshow (when initialized)
    • tile_grid (when shapes are drawn on screen)

Type of change

  • New feature (non-breaking change which adds functionality)

Limitations:

Please describe limitations of this PR

Testing:

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Checklist:

  • My code follows the style guidelines of this project
  • My code has been formatted with npm run format and passes the checks in npm run check
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment thread src/clue/adafruit_clue.py

@andreamah Andrea Mah (andreamah) left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great 💖

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks for adding telemetry to unimplemented functions. This will help next interns prioritize features

@vandyliu
Vandy Liu (vandyliu) merged commit 42edd93 into dev Apr 8, 2020
@vandyliu
Vandy Liu (vandyliu) deleted the users/t-vali/clue-python-telemetry branch April 8, 2020 19:45
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants