Sitelet https://github.com/microsoft/vscode-python-devicesimulator/pull/300
Skip to content
This repository was archived by the owner on Dec 23, 2021. It is now read-only.

Telemetry for CLUE on frontend - #300

Merged
Vandy Liu (vandyliu) merged 4 commits into
devfrom
users/t-vali/clue-frontend-telemetry
Apr 7, 2020
Merged

Vandy Liu (vandyliu) merged 4 commits into
devfrom
users/t-vali/clue-frontend-telemetry

Conversation

@vandyliu

Copy link
Copy Markdown
Contributor

Description:

  • Added telemetry for CLUE on frontend (sensors, new file, debugger, button presses)

Type of change

  • New feature (non-breaking change which adds functionality)

Limitations:

Please describe limitations of this PR

Testing:

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Checklist:

  • My code follows the style guidelines of this project
  • My code has been formatted with npm run format and passes the checks in npm run check
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That was simpler than I expected. LGTM!

Comment thread src/service/telemetryHandlerService.ts Outdated

@andreamah Andrea Mah (andreamah) left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🛩✈🚀 Great work!

@vandyliu
Vandy Liu (vandyliu) merged commit 9132b54 into dev Apr 7, 2020
@vandyliu
Vandy Liu (vandyliu) deleted the users/t-vali/clue-frontend-telemetry branch April 7, 2020 20:55
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants