Sitelet https://github.com/microsoft/vscode-python-devicesimulator/pull/295
Skip to content
This repository was archived by the owner on Dec 23, 2021. It is now read-only.

Getting Started Update for CLUE! - #295

Merged
Vandy Liu (vandyliu) merged 14 commits into
devfrom
users/t-vali/getting-started-clue
Apr 6, 2020
Merged

Vandy Liu (vandyliu) merged 14 commits into
devfrom
users/t-vali/getting-started-clue

Conversation

@vandyliu

@vandyliu Vandy Liu (vandyliu) commented Apr 2, 2020 •

Copy link
Copy Markdown
Contributor

AB#34303

Description:

  • Changed name of CPX from "CPX" to "Circuit Playground Express" to be consistent with command pallet
  • Updated indentation of code blocks to 4 spaces instead of 2 spaces
  • Added step 5 for micro:bit
  • Added entire section for CLUE
    CLUE Getting Started
  • Any and all opinions welcomed!

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

Limitations:

Please describe limitations of this PR

Testing:

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Checklist:

  • My code follows the style guidelines of this project
  • My code has been formatted with npm run format and passes the checks in npm run check
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work! Thanks for helping me with this

Comment thread src/view/pages/gettingStarted.tsx Outdated
Comment thread src/view/pages/gettingStarted.tsx Outdated

@andreamah Andrea Mah (andreamah) left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The page looks great! (●'◡'●)

Comment thread src/view/pages/__snapshots__/gettingStarted.spec.tsx.snap Outdated
Comment thread src/view/pages/__snapshots__/gettingStarted.spec.tsx.snap Outdated

@isadorasophia Isa (isadorasophia) left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool! 😁

Comment thread src/view/pages/gettingStarted.tsx
Comment thread src/view/pages/gettingStarted.tsx Outdated

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vandyliu
Vandy Liu (vandyliu) merged commit 52e4e67 into dev Apr 6, 2020
@vandyliu
Vandy Liu (vandyliu) deleted the users/t-vali/getting-started-clue branch April 6, 2020 19:21
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants