Sitelet https://github.com/microsoft/vscode-python-devicesimulator/pull/274
Skip to content
This repository was archived by the owner on Dec 23, 2021. It is now read-only.

README change (more stuff for microbit) part 2 - #274

Merged
Vandy Liu (vandyliu) merged 3 commits into
devfrom
users/t-vali/readme-change-part2
Mar 23, 2020
Merged

README change (more stuff for microbit) part 2#274
Vandy Liu (vandyliu) merged 3 commits into
devfrom
users/t-vali/readme-change-part2

Conversation

@vandyliu

@vandyliu Vandy Liu (vandyliu) commented Mar 23, 2020 •
edited by azure-boards Bot
Loading

Copy link
Copy Markdown
Contributor

AB#34117

Description:

  • use absolute links instead of relative links
  • changed all usage of double quotes to single quotes for elements (eg. src="" to src='')
  • changed some alt names for images to be more specific

Limitations:

Please describe limitations of this PR

Testing:

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Checklist:

  • My code follows the style guidelines of this project
  • My code has been formatted with npm run format and passes the checks in npm run check
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

nasadigital
David Serafimov (nasadigital) approved these changes Mar 23, 2020
View reviewed changes

@nasadigital David Serafimov (nasadigital) left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

Comment thread README.md Outdated
andreamah
Andrea Mah (andreamah) approved these changes Mar 23, 2020
View reviewed changes

@andreamah Andrea Mah (andreamah) left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks! 😁

@vandyliu
Vandy Liu (vandyliu) merged commit 240beef into dev Mar 23, 2020
@vandyliu
Vandy Liu (vandyliu) deleted the users/t-vali/readme-change-part2 branch March 23, 2020 18:06
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@abmahdy Ahmed Mahdy (abmahdy) Awaiting requested review from abmahdy abmahdy is a code owner
@adclements Andrew Clements (adclements) Awaiting requested review from adclements adclements is a code owner
@iennae Jennifer Davis (iennae) Awaiting requested review from iennae
@isadorasophia Isa (isadorasophia) Awaiting requested review from isadorasophia
@markAtMicrosoft Mark Schramm (markAtMicrosoft) Awaiting requested review from markAtMicrosoft
@sagarmanchanda Sagar Manchanda (sagarmanchanda) Awaiting requested review from sagarmanchanda sagarmanchanda is a code owner
@smmatte smmatte Awaiting requested review from smmatte smmatte is a code owner
2 more reviewers
@nasadigital David Serafimov (nasadigital) nasadigital approved these changes
@andreamah Andrea Mah (andreamah) andreamah approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@vandyliu @nasadigital @andreamah