Sitelet https://github.com/microsoft/vscode-python-devicesimulator/pull/265
Skip to content
This repository was archived by the owner on Dec 23, 2021. It is now read-only.

Removing preview mode - #265

Merged
Vandy Liu (vandyliu) merged 3 commits into
devfrom
users/t-vali/remove-preview-mode
Mar 19, 2020
Merged

Removing preview mode#265
Vandy Liu (vandyliu) merged 3 commits into
devfrom
users/t-vali/remove-preview-mode

Conversation

@vandyliu

@vandyliu Vandy Liu (vandyliu) commented Mar 18, 2020 •
edited by azure-boards Bot
Loading

Copy link
Copy Markdown
Contributor

AB#34122

Description:

  • Removed preview mode setting, so microbit commands show up regardless
  • If anyone has a better idea to remove it so that it is easy to add once again (for clue), please let me know

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

Limitations:

Please describe limitations of this PR

Testing:

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Checklist:

  • My code follows the style guidelines of this project
  • My code has been formatted with npm run format and passes the checks in npm run check
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

nasadigital
David Serafimov (nasadigital) approved these changes Mar 18, 2020
View reviewed changes

@nasadigital David Serafimov (nasadigital) left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
Are you sure you want to delete preview mode? If you add any new devices, I assume you would first offer them through the preview mode.
You would need to add everything back in that case, right?

andreamah
Andrea Mah (andreamah) approved these changes Mar 18, 2020
View reviewed changes

@andreamah Andrea Mah (andreamah) left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and good! 😎

@vandyliu

Vandy Liu (vandyliu) commented Mar 18, 2020 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

LGTM.
Are you sure you want to delete preview mode? If you add any new devices, I assume you would first offer them through the preview mode.
You would need to add everything back in that case, right?

David Serafimov (@nasadigital)
Yeah, we would have to add everything back. I'm not sure what the best way to do this is. Maybe we can hold off on this until we decide on a release date for sure?

@nasadigital

David Serafimov (nasadigital) commented Mar 18, 2020

Copy link
Copy Markdown

David Serafimov (@nasadigital)
Yeah, we would have to add everything back. I'm not sure what the best way to do this is. Maybe we can hold off on this until we decide on a release date for sure?

Vandy Liu (@vandyliu) Up to you! Was just curious.

@vandyliu
Vandy Liu (vandyliu) merged commit 3810e54 into dev Mar 19, 2020
@vandyliu
Vandy Liu (vandyliu) deleted the users/t-vali/remove-preview-mode branch March 19, 2020 17:47
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@abmahdy Ahmed Mahdy (abmahdy) Awaiting requested review from abmahdy abmahdy is a code owner
@adclements Andrew Clements (adclements) Awaiting requested review from adclements adclements is a code owner
@iennae Jennifer Davis (iennae) Awaiting requested review from iennae
@isadorasophia Isa (isadorasophia) Awaiting requested review from isadorasophia
@markAtMicrosoft Mark Schramm (markAtMicrosoft) Awaiting requested review from markAtMicrosoft
@sagarmanchanda Sagar Manchanda (sagarmanchanda) Awaiting requested review from sagarmanchanda sagarmanchanda is a code owner
@smmatte smmatte Awaiting requested review from smmatte smmatte is a code owner
@xnkevinnguyen Kevin Nguyen (xnkevinnguyen) Awaiting requested review from xnkevinnguyen
2 more reviewers
@nasadigital David Serafimov (nasadigital) nasadigital approved these changes
@andreamah Andrea Mah (andreamah) andreamah approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@vandyliu @nasadigital @andreamah