Sitelet https://github.com/microsoft/vscode-python-devicesimulator/pull/261
Skip to content
This repository was archived by the owner on Dec 23, 2021. It is now read-only.

Description UI change to Callout - #261

Merged
Vandy Liu (vandyliu) merged 17 commits into
devfrom
users/t-vali/description-ui-change
Mar 18, 2020
Merged

Description UI change to Callout#261
Vandy Liu (vandyliu) merged 17 commits into
devfrom
users/t-vali/description-ui-change

Conversation

@vandyliu

@vandyliu Vandy Liu (vandyliu) commented Mar 16, 2020 •
edited by azure-boards Bot
Loading

Copy link
Copy Markdown
Contributor

AB#34026

Description:

  • Note: my vscode color settings are a little messed up on my computer so the GIF colors may look off so take a look for yourselves
  • Changed description to a callout
  • Removed scroll from sensor modal (so that there is only one scroll bar: the main one)
    Light Mode Change
    High Contrast Mode Change
    Dark Mode Change

Type of change

  • New feature (non-breaking change which adds functionality)

Limitations:

Please describe limitations of this PR

Testing:

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Manual testing
  • Test A
  • Test B

Checklist:

  • My code follows the style guidelines of this project
  • My code has been formatted with npm run format and passes the checks in npm run check
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

@xnkevinnguyen

Kevin Nguyen (xnkevinnguyen) commented Mar 16, 2020

Copy link
Copy Markdown
Contributor

Awesome work Vandy! Good work on the frontend side :)

andreamah
Andrea Mah (andreamah) approved these changes Mar 16, 2020
View reviewed changes

@andreamah Andrea Mah (andreamah) left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks amazing! Thanks for all of your hard work 😊

@nasadigital

David Serafimov (nasadigital) commented Mar 18, 2020

Copy link
Copy Markdown

This is how it looks for me:
i_before
After hovering:
2020-03-18
Any idea why this is happening?

nasadigital
David Serafimov (nasadigital) reviewed Mar 18, 2020
View reviewed changes
Comment thread src/view/styles/ToolBar.css Outdated
nasadigital
David Serafimov (nasadigital) reviewed Mar 18, 2020
View reviewed changes
Comment thread src/view/components/toolbar/ToolBar.tsx
@vandyliu

Vandy Liu (vandyliu) commented Mar 18, 2020 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

This is how it looks for me:
i_before
After hovering:
2020-03-18
Any idea why this is happening?

David Serafimov (@nasadigital)
Did you run npm i before compiling? That's the only thing I can think of right now.

@nasadigital

David Serafimov (nasadigital) commented Mar 18, 2020 •
edited
Loading

Copy link
Copy Markdown

Vandy Liu (@vandyliu) Yup, tried it again but it looks the same.
I ran:

$ npm install
$ npm run compile

followed by "Run Extension" in VS Code.
Do you know if this issue is likely because of my setup or if it will be something more widespread?
By the way, the tooltip shows the description properly it's only the icon that is not showing.

@xnkevinnguyen

Kevin Nguyen (xnkevinnguyen) commented Mar 18, 2020

Copy link
Copy Markdown
Contributor

Vandy Liu (@vandyliu) Yup, tried it again but it looks the same.
I ran:

$ npm install
$ npm run compile

followed by "Run Extension" in VS Code.
Do you know if this issue is likely because of my setup or if it will be something more widespread?
By the way, the tooltip shows the description properly it's only the icon that is not showing.

Sometimes Vscode seems to not load some elements on the webview correctly. Try closing vscode and reopening it if that's not already done.

@nasadigital

David Serafimov (nasadigital) commented Mar 18, 2020

Copy link
Copy Markdown

Sometimes Vscode seems to not load some elements on the webview correctly. Try closing vscode and reopening it if that's not already done.

Kevin Nguyen (@xnkevinnguyen) That's interesting. I reopened VS Code multiple times, but should I try uninstall -> install?

nasadigital
David Serafimov (nasadigital) approved these changes Mar 18, 2020
View reviewed changes

@nasadigital David Serafimov (nasadigital) left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Great job!

@vandyliu
Vandy Liu (vandyliu) merged commit 75b7040 into dev Mar 18, 2020
@vandyliu
Vandy Liu (vandyliu) deleted the users/t-vali/description-ui-change branch March 18, 2020 20:47
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@xnkevinnguyen Kevin Nguyen (xnkevinnguyen) Awaiting requested review from xnkevinnguyen
@abmahdy Ahmed Mahdy (abmahdy) Awaiting requested review from abmahdy abmahdy is a code owner
@adclements Andrew Clements (adclements) Awaiting requested review from adclements adclements is a code owner
@iennae Jennifer Davis (iennae) Awaiting requested review from iennae
@isadorasophia Isa (isadorasophia) Awaiting requested review from isadorasophia
@markAtMicrosoft Mark Schramm (markAtMicrosoft) Awaiting requested review from markAtMicrosoft
@sagarmanchanda Sagar Manchanda (sagarmanchanda) Awaiting requested review from sagarmanchanda sagarmanchanda is a code owner
@smmatte smmatte Awaiting requested review from smmatte smmatte is a code owner
2 more reviewers
@nasadigital David Serafimov (nasadigital) nasadigital approved these changes
@andreamah Andrea Mah (andreamah) andreamah approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@vandyliu @xnkevinnguyen @nasadigital @andreamah