Sitelet https://github.com/microsoft/vscode-python-devicesimulator/pull/242
Skip to content
This repository was archived by the owner on Dec 23, 2021. It is now read-only.

Get serial monitor working with micro:bit and CPX - #242

Merged
Vandy Liu (vandyliu) merged 3 commits into
devfrom
users/t-vali/serial-monitor-abstract
Mar 4, 2020
Merged

Vandy Liu (vandyliu) merged 3 commits into
devfrom
users/t-vali/serial-monitor-abstract

Conversation

@vandyliu

Copy link
Copy Markdown
Contributor

Description:

  • Serial monitor works for CPX and micro:bit
  • They have the same code, so there wasn't much chance except changing everything that said 'CPX' to 'common'

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

Limitations:

Please describe limitations of this PR

Testing:

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Tested all commands with CPX and micro:bit
  • Test A
  • Test B

Checklist:

  • My code follows the style guidelines of this project
  • My code has been formatted with npm run format and passes the checks in npm run check
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

@isadorasophia Isa (isadorasophia) left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice clean up!

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, I tested it and it works flawlessly

@vandyliu
Vandy Liu (vandyliu) merged commit bc5d090 into dev Mar 4, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants