Sitelet https://github.com/microsoft/vscode-python-devicesimulator/pull/207
Skip to content
This repository was archived by the owner on Dec 23, 2021. It is now read-only.

command pallet reconfiguration - #207

Merged
Kevin Nguyen (xnkevinnguyen) merged 3 commits into
devfrom
users/t-vali/command-pallet-reconfig
Feb 19, 2020
Merged

Kevin Nguyen (xnkevinnguyen) merged 3 commits into
devfrom
users/t-vali/command-pallet-reconfig

Conversation

@vandyliu

@vandyliu Vandy Liu (vandyliu) commented Feb 18, 2020 •

Copy link
Copy Markdown
Contributor

Description:

  • Refactored commands in command pallete to include whether it is a CPX or microbit command
  • Removed top icons (run simulator, open simulator, deploy)

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

Limitations:

Please describe limitations of this PR

Testing:

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Checklist:

  • My code follows the style guidelines of this project
  • My code has been formatted with npm run format and passes the checks in npm run check
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

Comment thread package.json
@vandyliu Vandy Liu (vandyliu) changed the title WIP: command pallet reconfig command pallet reconfiguration Feb 19, 2020

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vandyliu
Vandy Liu (vandyliu) deleted the users/t-vali/command-pallet-reconfig branch February 19, 2020 17:53
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants