Sitelet https://github.com/microsoft/vscode-python-devicesimulator/pull/202
Skip to content
This repository was archived by the owner on Dec 23, 2021. It is now read-only.

Build status of azure pipelines in README.MD - #202

Merged
Vandy Liu (vandyliu) merged 5 commits into
devfrom
users/t-vali/build-status-on-readme
Feb 13, 2020
Merged

Vandy Liu (vandyliu) merged 5 commits into
devfrom
users/t-vali/build-status-on-readme

Conversation

@vandyliu

Copy link
Copy Markdown
Contributor

Description:

Build status of azure pipelines in README.MD. I'm not sure if the placement is best. Please let me know your thoughts.

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

Limitations:

Please describe limitations of this PR

Testing:

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Checklist:

  • My code follows the style guidelines of this project
  • My code has been formatted with npm run format and passes the checks in npm run check
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
Totally ok to drop master if you want, since it seems we are not using it, yet.

@vandyliu

Copy link
Copy Markdown
Contributor Author

LGTM.
Totally ok to drop master if you want, since it seems we are not using it, yet.

Yeah, I was considering it but I think we will be using master soon so I decided to include it

@vandyliu Vandy Liu (vandyliu) changed the title Build status of azure pipelines in README.MD WIP: Build status of azure pipelines in README.MD Feb 12, 2020

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@vandyliu Vandy Liu (vandyliu) changed the title WIP: Build status of azure pipelines in README.MD Build status of azure pipelines in README.MD Feb 13, 2020
@vandyliu
Vandy Liu (vandyliu) merged commit 8891bf5 into dev Feb 13, 2020
@vandyliu
Vandy Liu (vandyliu) deleted the users/t-vali/build-status-on-readme branch February 13, 2020 18:13
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants