This repository was archived by the owner on Dec 23, 2021. It is now read-only.
re-worked first-time dependency install - #198
Merged
Andrea Mah (andreamah) merged 4 commits intoFeb 12, 2020
Merged
Andrea Mah (andreamah) merged 4 commits into
Andrea Mah (andreamah) merged 4 commits into
Conversation
Andrea Mah (andreamah)
requested review from
Vandy Liu (vandyliu) and
Kevin Nguyen (xnkevinnguyen)
February 11, 2020 22:27
Contributor
|
Nice pr! It will make the onboarding experience better for a lot of people :) |
Isa (isadorasophia)
approved these changes
Feb 11, 2020
Isa (isadorasophia)
left a comment
Contributor
There was a problem hiding this comment.
Loved the option for "Install Extension Dependencies"! ☃️
Andrea Mah (andreamah)
deleted the
users/t-anmah/dependency-download-experience-improvement
branch
February 12, 2020 00:20
Comment on lines
+55
to
+57
| "command": "deviceSimulatorExpress.closeSerialMonitor", | ||
| "title": "%deviceSimulatorExpressExtension.commands.closeSerialMonitor%", | ||
| "category": "%deviceSimulatorExpressExtension.commands.label%" |
Contributor
There was a problem hiding this comment.
change this to openSerialMonitor
Andrea Mah (andreamah)
restored the
users/t-anmah/dependency-download-experience-improvement
branch
February 12, 2020 00:26
Vandy Liu (vandyliu)
left a comment
Contributor
There was a problem hiding this comment.
Nice stuff!
Andrea Mah (andreamah)
added a commit
that referenced
this pull request
Feb 12, 2020
This reverts commit a8cd70d.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Dependency install pop-up is now harder to ignore upon first install, reducing the chance that users accidentally skip out on dependency install. There is also now an option to install dependencies in the ctrl+shift+p menu, in case users deny downloading dependencies the first time.
NOTE: if you want to disable the dependency prompt because you have the pip packages installed globally, the option is available in settings (from before)
Type of change
Please delete options that are not relevant.
Limitations:
Testing:
Checklist:
npm run formatand passes the checks innpm run check